Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMP-111643 Update Taxonomy API docs #329

Merged
merged 5 commits into from
Oct 24, 2024

Conversation

rahulmuthyam
Copy link
Contributor

  1. Add overrideScope and classifications wherever necessary for DAC GA.
  2. Document new Group Properties API.

Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
amplitude-docs ✅ Ready (Inspect) Visit Preview Oct 18, 2024 6:07pm

@rahulmuthyam
Copy link
Contributor Author

rahulmuthyam commented Oct 15, 2024

No idea why the preview link leads to a 404 (https://amplitude-docs-git-amp-111643-dac-taxonomy-5a1416-amplitude-inc.vercel.app/docs/apis/analytics/taxonomy) 😦.

Maybe I missed something cc @markzegarelli or @SpencerFleury

@markzegarelli
Copy link
Member

No idea why the preview link leads to a 404 (https://amplitude-docs-git-amp-111643-dac-taxonomy-5a1416-amplitude-inc.vercel.app/docs/apis/analytics/taxonomy) 😦.

Maybe I missed something cc @markzegarelli or @SpencerFleury

Hi @rahulmuthyam, this 404 is due to a timeout of our code highlighting service. This can happen in preview builds from time to time when there is a page with a lot of highlighting, as is the case here.

Production builds don't have this issue. You can preview the changes locally if you've set up the environment.

content/collections/api/en/taxonomy.md Outdated Show resolved Hide resolved
content/collections/api/en/taxonomy.md Outdated Show resolved Hide resolved
content/collections/api/en/taxonomy.md Outdated Show resolved Hide resolved
content/collections/api/en/taxonomy.md Outdated Show resolved Hide resolved
content/collections/api/en/taxonomy.md Outdated Show resolved Hide resolved
content/collections/api/en/taxonomy.md Outdated Show resolved Hide resolved
content/collections/api/en/taxonomy.md Outdated Show resolved Hide resolved
content/collections/api/en/taxonomy.md Outdated Show resolved Hide resolved
content/collections/api/en/taxonomy.md Outdated Show resolved Hide resolved
content/collections/api/en/taxonomy.md Outdated Show resolved Hide resolved
@rahulmuthyam
Copy link
Contributor Author

rahulmuthyam commented Oct 17, 2024

No idea why the preview link leads to a 404 (https://amplitude-docs-git-amp-111643-dac-taxonomy-5a1416-amplitude-inc.vercel.app/docs/apis/analytics/taxonomy) 😦.
Maybe I missed something cc @markzegarelli or @SpencerFleury

Hi @rahulmuthyam, this 404 is due to a timeout of our code highlighting service. This can happen in preview builds from time to time when there is a page with a lot of highlighting, as is the case here.

Production builds don't have this issue. You can preview the changes locally if you've set up the environment.

Thanks for letting me know. I did preview it locally before creating this PR.

Co-authored-by: SpencerFleury <159941756+SpencerFleury@users.noreply.github.com>
@markzegarelli
Copy link
Member

@rahulmuthyam Is there anything else needed for this PR? Are we waiting for a specific date to push the docs?

@rahulmuthyam
Copy link
Contributor Author

@rahulmuthyam Is there anything else needed for this PR? Are we waiting for a specific date to push the docs?

Hi @markzegarelli, thanks for the ping! I was waiting for some of my changes to be pushed to prod but that's done yesterday. Merging this in.

@rahulmuthyam rahulmuthyam merged commit 7140486 into main Oct 24, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants