Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-319 SR Mobile GA #355

Merged
merged 13 commits into from
Oct 30, 2024
Merged

DOC-319 SR Mobile GA #355

merged 13 commits into from
Oct 30, 2024

Conversation

markzegarelli
Copy link
Member

For both iOS and Android:

  • Middleware setup instructions added to Plugin article
  • Removed Alpha mentions
  • Added links to GitHub repos for raising issues
  • Mentioned remote config and disabling for local testing

Need more info:

  • Add details on privacy config including references to iOS and Android manifests. Not sure on the last part.

Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
amplitude-docs 🛑 Canceled (Inspect) Oct 30, 2024 11:36pm

@izaaz
Copy link

izaaz commented Oct 29, 2024

In the android docs, we have a section about jetpack compose masking. Can we remove that section? We don't support jetpack compose today.

And can we add a note on the android docs that jetpack compose is currently not supported?

@izaaz
Copy link

izaaz commented Oct 29, 2024

We can also remove this section. We don't have a list of supported view components anymore

https://amplitude-docs-git-doc-319-amplitude-inc.vercel.app/docs/session-replay/session-replay-android-plugin#supported-view-components

@izaaz
Copy link

izaaz commented Oct 29, 2024

Session Replay requires that the Android SDK send [Amplitude] Session Start and [Amplitude] Session End events, at a minimum

We don't need these two events anymore. We can just say that Session Replay requires at least one event to be tagged with the session replay id.

@izaaz
Copy link

izaaz commented Oct 29, 2024

We also want to add information around privacy masking levels. I believe there's a config for it and the default mask level is medium.

@markzegarelli
Copy link
Member Author

We also want to add information around privacy masking levels. I believe there's a config for it and the default mask level is medium.

@izaaz We have this document already written about masking levels. Can I link here and broaden it to not specifically mention CSS?

@izaaz
Copy link

izaaz commented Oct 30, 2024

We also want to add information around privacy masking levels. I believe there's a config for it and the default mask level is medium.

@izaaz We have this document already written about masking levels. Can I link here and broaden it to not specifically mention CSS?

The privacy configs for mobile are a little different. If we were to point to this, how would we differentiate between web and mobile? Also, that page looks very web focused.

@markzegarelli
Copy link
Member Author

We also want to add information around privacy masking levels. I believe there's a config for it and the default mask level is medium.

@izaaz We have this document already written about masking levels. Can I link here and broaden it to not specifically mention CSS?

The privacy configs for mobile are a little different. If we were to point to this, how would we differentiate between web and mobile? Also, that page looks very web focused.

Got it. Do you have any details on masking on Mobile? Flying a bit blind on that.

Also, want to confirm that maskLevel is supported across all SDKs at this point.

markzegarelli and others added 4 commits October 30, 2024 16:25
Co-authored-by: SpencerFleury <159941756+SpencerFleury@users.noreply.github.com>
…lugin.md

Co-authored-by: SpencerFleury <159941756+SpencerFleury@users.noreply.github.com>
….antlers.html

Co-authored-by: SpencerFleury <159941756+SpencerFleury@users.noreply.github.com>
@markzegarelli markzegarelli merged commit fadac2d into main Oct 30, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants