feat: amplitude-core package for seamless integration with analytics #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgiori
changed the title
bgiori
requested review from
justin-fiedler,
qingzhuozhen,
curtisliu and
nirmal91
|
|
||
| defaultConfig { | ||
| minSdkVersion 14 | ||
| targetSdkVersion 30 |
There was a problem hiding this comment.
The target SDK version now on Android SDK is 28. What's the version for Experiment now?
There was a problem hiding this comment.
target and min sdk version is the same in core and Experiment SDK (30 and 14 respectively)
github-actions bot
pushed a commit
that referenced
this pull request
Feb 12, 2022
# [1.5.0](1.4.0...1.5.0) (2022-02-12) ### Features * add exposure tracking provider ([#15](#15)) ([5a2a471](5a2a471)) * core package for seamless integration with analytics ([#12](#12)) ([95addb3](95addb3)) * rename amplitude-core to analytics-connector ([#13](#13)) ([da7a11c](da7a11c)) * use exposure-v2 in connector analytics provider ([#14](#14)) ([afe9cfc](afe9cfc))
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds a
coremodule which implements interactions between amplitude analytics and experiment.More here: https://amplitude.atlassian.net/wiki/spaces/EXP/pages/1683980404/Amplitude+SDK+Core
I have decided not to implement an initialization resolver or component registrar since I felt that it did not serve enough of a purpose and future implementation may have more context to write a better version.