-
Notifications
You must be signed in to change notification settings - Fork 243
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix for issue #1302: "SSR: Duplicated ids in rendered markup, if ther…
…e are nodes with attributes 'media', 'heights' or 'sizes'" (#1303) * fix duplicated ids * Added transformation test and refactored fix. * Adjusted input.html of transformation test with more realistic example
- Loading branch information
1 parent
c15aa62
commit c85646a
Showing
3 changed files
with
30 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
...erates_unique_ids_for_items_with_media_and_ignores_items_with_own_id/expected_output.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| <!DOCTYPE html> | ||
| <html ⚡ i-amphtml-layout i-amphtml-no-boilerplate> | ||
| <head><style amp-runtime></style> | ||
| <script data-rh async src="https://cdn.ampproject.org/v0.js"></script> | ||
| <style amp-custom>@media not all and (min-width: 0px) and (max-width: 50px){#i-amp-0{display:none}}@media not all and (min-width: 51px) and (max-width: 129px){#i-amp-1{display:none}}</style> | ||
| </head> | ||
| <body> | ||
| <amp-img height="100" width="100" layout="responsive" src="img1.png" class="i-amphtml-layout-responsive i-amphtml-layout-size-defined" i-amphtml-layout="responsive" id="i-amp-0"> | ||
| <i-amphtml-sizer slot="i-amphtml-svc" style="display:block;padding-top:100%"></i-amphtml-sizer> | ||
| </amp-img> | ||
| <amp-img id="customId" height="100" width="100" layout="responsive" src="img2.png" class="i-amphtml-layout-responsive i-amphtml-layout-size-defined" i-amphtml-layout="responsive"> | ||
| <i-amphtml-sizer slot="i-amphtml-svc" style="display:block;padding-top:100%"></i-amphtml-sizer> | ||
| </amp-img> | ||
| <amp-img height="100" width="100" layout="responsive" src="img3.png" class="i-amphtml-layout-responsive i-amphtml-layout-size-defined" i-amphtml-layout="responsive" id="i-amp-1"> | ||
| <i-amphtml-sizer slot="i-amphtml-svc" style="display:block;padding-top:100%"></i-amphtml-sizer> | ||
| </amp-img> | ||
| </body> | ||
| </html> |
11 changes: 11 additions & 0 deletions
11
...dering/generates_unique_ids_for_items_with_media_and_ignores_items_with_own_id/input.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| <!DOCTYPE html> | ||
| <html ⚡> | ||
| <head> | ||
| <script data-rh="" async="" src="https://cdn.ampproject.org/v0.js"></script> | ||
| </head> | ||
| <body> | ||
| <amp-img media="(min-width: 0px) and (max-width: 50px)" height="100" width="100" layout="responsive" src="img1.png"></amp-img> | ||
| <amp-img id="customId" height="100" width="100" layout="responsive" src="img2.png"></amp-img> | ||
| <amp-img media="(min-width: 51px) and (max-width: 129px)" height="100" width="100" layout="responsive" src="img3.png"></amp-img> | ||
| </body> | ||
| </html> |