fix auto fetching of "latestVersion" configuration from amphtml repo #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sebastianbenz what is the different between |
erwinmombay
force-pushed
the
fix-auto-importer
branch
2 times, most recently
from
bf41d59 to
42cc87d
Compare
erwinmombay
force-pushed
the
fix-auto-importer
branch
from
42cc87d to
486964c
Compare
sebastianbenz
approved these changes
Jan 10, 2022
| throw new Error(`Failed downloading ${extensionConfigUrl} with status ${response.status}`); | ||
| const latestVersionsUrl = `https://raw.githubusercontent.com/ampproject/amphtml/main/build-system/compile/bundles.legacy-latest-versions.jsonc`; | ||
|
|
||
| const configResponse = await fetch(extensionConfigUrl); |
There was a problem hiding this comment.
Can we parallelize the two requests?
There was a problem hiding this comment.
yes. ill make the change
| // We add back the "latestVersion" field so that the auto importer | ||
| // code knows what "stable" version of the extension to use. | ||
| extensionConfig.forEach((entry) => { | ||
| entry['latestVersion'] = latestVersionsConfig[entry.name]; |
samouri
approved these changes
Jan 10, 2022
westonruter
reviewed
Jan 10, 2022
| const response = await fetch(extensionConfigUrl); | ||
| if (!response.ok) { | ||
| throw new Error(`Failed downloading ${extensionConfigUrl} with status ${response.status}`); | ||
| const latestVersionsUrl = `https://raw.githubusercontent.com/ampproject/amphtml/main/build-system/compile/bundles.legacy-latest-versions.jsonc`; |
There was a problem hiding this comment.
Cool. I've essentially taken this same approach in ampproject/amp-wp#6803.
erwinmombay
added a commit
to erwinmombay/amp-toolbox
that referenced
this pull request
Jan 12, 2022
This is no longer needed as the ampproject#1273 brings back the "latestVersion" in the configuration
sebastianbenz
pushed a commit
that referenced
this pull request
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the previous fix which assumed that the highest version of an extension should be automatically used by the auto importer is incorrect. for example on some instances the newest version is not yet in stable and should not be used.
We fetch the frozen latest version configuration and merge it to generate an "extensionConfig.json" with a "latestVersion" field