Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the latestVersion fix #1282

Merged
merged 4 commits into from
Jan 12, 2022

Conversation

erwinmombay
Copy link
Member

@erwinmombay erwinmombay commented Jan 12, 2022

This is no longer needed as the #1273 brings back the "latestVersion" in the configuration

This is no longer needed as the ampproject#1273
brings back the "latestVersion" in the configuration
@erwinmombay erwinmombay force-pushed the remove-latest-version-fix branch from 7f1e8de to a439496 Compare January 12, 2022 22:43
@sebastianbenz sebastianbenz merged commit 1b7e896 into ampproject:main Jan 12, 2022
@samouri
Copy link
Member

samouri commented Jan 13, 2022

I don't necessarily agree. I think best case scenario we still figure out a way to remove latestVersion from that json file.
See ampproject/amphtml#36749 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants