From 7508b81eab8e3cbe61f9aa0d7970ad43c4c22c87 Mon Sep 17 00:00:00 2001 From: Alain Schlesser Date: Fri, 12 Jun 2020 23:38:40 +0200 Subject: [PATCH 1/3] Fix text spacing --- lib/optimizer/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/optimizer/README.md b/lib/optimizer/README.md index 17f379a3e68..bf6a0b13029 100644 --- a/lib/optimizer/README.md +++ b/lib/optimizer/README.md @@ -33,7 +33,7 @@ The AMP Optimizer is a `AmpProject\Optimizer\TransformationEngine` object that s During the process, errors might occur that make parts of the optimization impossible. These are collected within an `AmpProject\Optimizer\ErrorCollection` object that you can then iterate over to find out more and provide feedback as needed. -![Diagram showing the conceptual parts of the AMP Optimizer](https://via.placeholder.com/1200x400.png?text=Conceptual overview diagram) +![Diagram showing the conceptual parts of the AMP Optimizer](https://via.placeholder.com/1200x400.png?text=Conceptual%20overview%20diagram) ## Installation From 70158050ec51e5d29592ac789815e580d103503b Mon Sep 17 00:00:00 2001 From: Alain Schlesser Date: Sat, 13 Jun 2020 00:07:54 +0200 Subject: [PATCH 2/3] Add conceptual diagram --- lib/optimizer/README.md | 2 +- lib/optimizer/conceptual-diagram.svg | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) create mode 100644 lib/optimizer/conceptual-diagram.svg diff --git a/lib/optimizer/README.md b/lib/optimizer/README.md index bf6a0b13029..c3ad7b1e0de 100644 --- a/lib/optimizer/README.md +++ b/lib/optimizer/README.md @@ -33,7 +33,7 @@ The AMP Optimizer is a `AmpProject\Optimizer\TransformationEngine` object that s During the process, errors might occur that make parts of the optimization impossible. These are collected within an `AmpProject\Optimizer\ErrorCollection` object that you can then iterate over to find out more and provide feedback as needed. -![Diagram showing the conceptual parts of the AMP Optimizer](https://via.placeholder.com/1200x400.png?text=Conceptual%20overview%20diagram) +![Diagram showing the conceptual parts of the AMP Optimizer](conceptual-diagram.svg) ## Installation diff --git a/lib/optimizer/conceptual-diagram.svg b/lib/optimizer/conceptual-diagram.svg new file mode 100644 index 00000000000..7b089c284dd --- /dev/null +++ b/lib/optimizer/conceptual-diagram.svg @@ -0,0 +1 @@ + \ No newline at end of file From 3a89be0fbaa5e00db45110311506ff6df32a86f6 Mon Sep 17 00:00:00 2001 From: Alain Schlesser Date: Sat, 13 Jun 2020 00:19:49 +0200 Subject: [PATCH 3/3] Update diagram SVG file --- lib/optimizer/conceptual-diagram.svg | 475 ++++++++++++++++++++++++++- 1 file changed, 474 insertions(+), 1 deletion(-) diff --git a/lib/optimizer/conceptual-diagram.svg b/lib/optimizer/conceptual-diagram.svg index 7b089c284dd..619f49a2be4 100644 --- a/lib/optimizer/conceptual-diagram.svg +++ b/lib/optimizer/conceptual-diagram.svg @@ -1 +1,474 @@ - \ No newline at end of file + + + + + + image/svg+xml + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +