-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fullscreen Mode Compatibility #2221
Labels
Bug
Something isn't working
Comments
swissspidy
changed the title
[AMP Stories] Fullscreen Mode Compatibility
Fullscreen Mode Compatibility
Apr 30, 2019
@swissspidy Are you still seeing this issue? Couldn't reproduce it at this moment. Did the following:
|
Indeed seems to work fine now with the latest Gutenberg version. Yay! Great that it's working. Fullscreen mode makes focusing on story creation so much easier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Creating a new story when fullscreen mode is active works fine, however there is an error when switching from regular to fullscreen mode when already editing a story:
This is probably due to the fact that we insert some custom HTML nodes and wrap some existing elements in our new nodes.
If there's not an easy way to solve this in JavaScript, one option would be to completely override the editor
Layout
component or similar to achieve our custom DOM structure.The text was updated successfully, but these errors were encountered: