Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen Mode Compatibility #2221

Closed
swissspidy opened this issue Apr 30, 2019 · 2 comments
Closed

Fullscreen Mode Compatibility #2221

swissspidy opened this issue Apr 30, 2019 · 2 comments
Labels
Bug Something isn't working

Comments

@swissspidy
Copy link
Collaborator

Creating a new story when fullscreen mode is active works fine, however there is an error when switching from regular to fullscreen mode when already editing a story:

Screenshot 2019-04-30 at 12 05 29

This is probably due to the fact that we insert some custom HTML nodes and wrap some existing elements in our new nodes.

If there's not an easy way to solve this in JavaScript, one option would be to completely override the editor Layout component or similar to achieve our custom DOM structure.

@swissspidy swissspidy added Bug Something isn't working AMP-Stories labels Apr 30, 2019
@swissspidy swissspidy changed the title [AMP Stories] Fullscreen Mode Compatibility Fullscreen Mode Compatibility Apr 30, 2019
@westonruter westonruter added this to the v1.2 milestone May 21, 2019
@swissspidy swissspidy removed this from the v1.2 milestone Jun 12, 2019
@MackenzieHartung MackenzieHartung added this to the v1.2.1 milestone Jun 12, 2019
@miina
Copy link
Contributor

miina commented Jun 17, 2019

@swissspidy Are you still seeing this issue? Couldn't reproduce it at this moment. Did the following:

  • Created a new Story in "normal" mode.
  • Added a few pages using the Templates Inserter.
  • Saved.
  • Switched to Fullscreen Mode.
  • Checked console for related errors -- none occurred.

@swissspidy swissspidy removed this from the v1.2.1 milestone Jun 17, 2019
@swissspidy
Copy link
Collaborator Author

Indeed seems to work fine now with the latest Gutenberg version. Yay!

Great that it's working. Fullscreen mode makes focusing on story creation so much easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants