Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E2E tests for the nav menu toggle #5404

Closed
westonruter opened this issue Sep 18, 2020 · 2 comments · Fixed by #6933 or #6967
Closed

Add E2E tests for the nav menu toggle #5404

westonruter opened this issue Sep 18, 2020 · 2 comments · Fixed by #6933 or #6967
Labels
Changelogged Whether the issue/PR has been added to release notes. Groomed P2 Low priority Punted Testing Issues related with Unit, E2E, Smoke, and other testing requirements/needs WS:Core Work stream for Plugin core
Milestone

Comments

@westonruter
Copy link
Member

Feature description

The 2.0.2 update broke the ability to toggle the mobile nav menu. See #5401 fixed by #5403. Given that the nav menu toggle is the most important interactive feature that almost all themes have, and given that it is the feature that almost always is broken when a theme is not AMP-compatible, we need to add E2E tests to ensure that this toggle works. This should be done for a theme that uses the AMP_Nav_Menu_Toggle_Sanitizer like Twenty Seventeen but also for themes that have their own implementation, like Twenty Twenty. While the regression was actually a fault with the CSS sanitizer and would have been caught by more extensive tests, the issue would have also been caught by an E2E test which would also ensure all the classes in between are also working properly, including the AMP_Core_Theme_Sanitizer (see #3729).


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

@westonruter westonruter added Testing Issues related with Unit, E2E, Smoke, and other testing requirements/needs WS:Core Work stream for Plugin core labels Sep 18, 2020
@westonruter westonruter added this to the v2.1 milestone Sep 18, 2020
@westonruter westonruter added the P1 Medium priority label Sep 18, 2020
@kmyram kmyram added the Groomed label Oct 27, 2020
@johnwatkins0 johnwatkins0 self-assigned this Dec 8, 2020
@johnwatkins0 johnwatkins0 removed their assignment Dec 30, 2020
@westonruter westonruter modified the milestones: v2.1, v2.2 Feb 11, 2021
@westonruter westonruter added P2 Low priority and removed P1 Medium priority labels Jun 18, 2021
@westonruter westonruter modified the milestones: v2.2, v2.3 Nov 30, 2021
@delawski delawski self-assigned this Feb 3, 2022
@westonruter westonruter modified the milestones: v2.3, v2.2.2 Mar 9, 2022
@westonruter
Copy link
Member Author

Re-opening because there's a failure for the Twenty Twenty test:

image

@westonruter
Copy link
Member Author

Aside: if it's feasible to add a test for Twenty Twenty-Two as well, that would be great.

@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelogged Whether the issue/PR has been added to release notes. Groomed P2 Low priority Punted Testing Issues related with Unit, E2E, Smoke, and other testing requirements/needs WS:Core Work stream for Plugin core
Projects
None yet
4 participants