Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate admin bar with AMP dev mode #3187

Merged
merged 23 commits into from
Sep 11, 2019
Merged

Commits on Sep 4, 2019

  1. Configuration menu
    Copy the full SHA
    3380451 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2019

  1. Skip sanitizing admin bar (and removing it) in favor of ignoring (in …

    …dev mode)
    
    * Eliminate need for keeping forked version of admin-bar.css in plugin.
    * Automatically add data-ampdevmode attributes to scripts and styles that depend on the admin bar, excluding them from being sanitized out of the document.
    * Skip processing stylesheets that have data-ampdevmode attributes.
    westonruter committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    e3d4f57 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2019

  1. Prevent tree-shaking under #wpadminbar when admin bar is showing

    Also add missing dynamic_element_selectors arg to stylesheet cache key.
    westonruter committed Sep 6, 2019
    Configuration menu
    Copy the full SHA
    8640d1a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f75586f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a81fb73 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bfad786 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5bb7466 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2019

  1. Bring back remove_admin_bar_if_css_excluded and admin-bar CSS priorit…

    …y for unauthenticated admin bars
    westonruter committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    d615d39 View commit details
    Browse the repository at this point in the history
  2. Prevent dev mode when admin bar shown for unauthenticated users

    Refactor methods to improve readability and organization
    westonruter committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    277131f View commit details
    Browse the repository at this point in the history
  3. Fix placement of dev_mode_enabled variable definition

    Add todo comments for where dev mode should be used instead of allow_dirty_*.
    Make closures static.
    westonruter committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    4b533d2 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2019

  1. Configuration menu
    Copy the full SHA
    e3025cd View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2019

  1. Fix typos in comments and add array casting

    Co-Authored-By: Alain Schlesser <alain.schlesser@gmail.com>
    westonruter and schlessera authored Sep 9, 2019
    Configuration menu
    Copy the full SHA
    a726d41 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2019

  1. Merge branch 'develop' of github.com:ampproject/amp-wp into add/dev-m…

    …ode-support
    
    * 'develop' of github.com:ampproject/amp-wp: (28 commits)
      Exclude development files from production build ZIPs
      Add filter to allow more video types in AMP story background se… (#3171)
      Update dependency @babel/cli to v7.6.0 (#3203)
      Update dependency @babel/core to v7.6.0 (#3204)
      Remove deprecated AMP_WP_Utils class
      Refresh Composer lock file
      Run build in a temporary folder
      Add shell script to clean up the current folder and then trigger a build
      Adapt Gruntfile to fetch optimized Composer dependencies within the build folder
      Retrieve Sabberworm patch directly from the GitHub PR
      Adding regression test for vertical text alignment issues
      Fixing minor errors in test descriptions
      Only restrict height inside non-fit text blocks
      Rewritten block size tests
      Limit height declaration to only direct descendant
      Remove now obsolete withEnforcedVideoUploadType HOC
      Update eslint-plugin-jest and apply fixes (#3192)
      Update dependency postcss to v7.0.18 (#3200)
      Update dependency terser-webpack-plugin to v2 (#3195)
      Update dependency webpack-cli to v3.3.8 (#3194)
      ...
    westonruter committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    58f5eb3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d1ac164 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5ba10b4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    38fa7ba View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    71c195c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2471036 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7c57708 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    e15bbe3 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    d79be8d View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2019

  1. Remove useless variable

    schlessera committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    5de22ff View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    290adf7 View commit details
    Browse the repository at this point in the history