From 937ecd5b535a87170837d9269a605a0132ab0d2d Mon Sep 17 00:00:00 2001 From: Pierre Gordon Date: Sat, 4 Apr 2020 15:20:42 -0400 Subject: [PATCH] Update optimizer test specs --- lib/optimizer/composer.json | 5 ++-- .../resources/local_fallback/rtv/metadata | 2 +- .../hello-world/expected_output.html | 3 ++- .../hello-world/expected_output.valid.html | 2 +- .../spec/end-to-end/hello-world/input.html | 3 ++- .../expected_output.html | 2 +- .../rewrites_hosts/expected_output.html | 2 +- .../minifies_inline_JSON/expected_output.html | 4 +-- .../minifies_inline_JSON/input.html | 2 ++ .../expected_output.html | 2 +- .../expected_output.html | 4 +-- .../expected_output.html | 4 +-- .../input.html | 2 +- .../expected_output.html | 4 +-- .../input.html | 2 +- .../moves_keyframes/expected_output.html | 4 +-- .../moves_keyframes/input.html | 4 +-- .../expected_output.html | 4 +-- .../input.html /input.html | 25 ------------------- 19 files changed, 30 insertions(+), 50 deletions(-) delete mode 100644 lib/optimizer/tests/spec/transformers/valid/ServerSideRendering/boilerplate_not_removed_when_amp_experiment_present/input.html /input.html diff --git a/lib/optimizer/composer.json b/lib/optimizer/composer.json index fc27a5bbb31..30b1e8bcad9 100644 --- a/lib/optimizer/composer.json +++ b/lib/optimizer/composer.json @@ -62,7 +62,7 @@ "cs": "if [ -z $TEST_SKIP_PHPCS ]; then phpcs --standard=PSR12 -s -n src tests; fi", "lint": "if [ -z $TEST_SKIP_LINTING ]; then parallel-lint -j 10 --colors --exclude vendor .; fi", "post-update-cmd": [ - "rm -rf tests/spec && bin/sync-amp-toolbox-test-suite.php", + "@update-test-specs", "bin/sync-amp-runtime-local-fallback-resources.php" ], "test": [ @@ -72,6 +72,7 @@ "@analyze" ], "analyze": "if [ -z $TEST_SKIP_PHPSTAN ]; then phpstan analyze --ansi; fi", - "unit": "if [ -z $TEST_SKIP_PHPUNIT ]; then phpunit --colors=always; fi" + "unit": "if [ -z $TEST_SKIP_PHPUNIT ]; then phpunit --colors=always; fi", + "update-test-specs": "rm -rf tests/spec && bin/sync-amp-toolbox-test-suite.php" } } diff --git a/lib/optimizer/resources/local_fallback/rtv/metadata b/lib/optimizer/resources/local_fallback/rtv/metadata index 9062bce9717..075574e4725 100644 --- a/lib/optimizer/resources/local_fallback/rtv/metadata +++ b/lib/optimizer/resources/local_fallback/rtv/metadata @@ -1 +1 @@ -{"ampRuntimeVersion":"012002251816300","ampCssUrl":"https://cdn.ampproject.org/rtv/012002251816300/v0.css","canaryPercentage":"0.005","diversions":["002002251816300","032002251816300","022002251816300"],"ltsRuntimeVersion":"012002191527100","ltsCssUrl":"https://cdn.ampproject.org/rtv/012002191527100/v0.css"} \ No newline at end of file +{"ampRuntimeVersion":"012004030010070","ampCssUrl":"https://cdn.ampproject.org/rtv/012004030010070/v0.css","canaryPercentage":"0.005","diversions":["002004012111560","002004012158290","022004030010070","032004012111560","032004012158290","042004030033570"],"ltsRuntimeVersion":"012002251816300","ltsCssUrl":"https://cdn.ampproject.org/rtv/012002251816300/v0.css"} \ No newline at end of file diff --git a/lib/optimizer/tests/spec/end-to-end/hello-world/expected_output.html b/lib/optimizer/tests/spec/end-to-end/hello-world/expected_output.html index 55b0a3fafb7..96c971120af 100644 --- a/lib/optimizer/tests/spec/end-to-end/hello-world/expected_output.html +++ b/lib/optimizer/tests/spec/end-to-end/hello-world/expected_output.html @@ -5,11 +5,12 @@ + - + diff --git a/lib/optimizer/tests/spec/end-to-end/hello-world/expected_output.valid.html b/lib/optimizer/tests/spec/end-to-end/hello-world/expected_output.valid.html index 43a844f5918..82bc3f473f1 100644 --- a/lib/optimizer/tests/spec/end-to-end/hello-world/expected_output.valid.html +++ b/lib/optimizer/tests/spec/end-to-end/hello-world/expected_output.valid.html @@ -8,7 +8,7 @@ - +

Hello, AMP world!

diff --git a/lib/optimizer/tests/spec/end-to-end/hello-world/input.html b/lib/optimizer/tests/spec/end-to-end/hello-world/input.html index 325d45d199d..5d3c471c95d 100644 --- a/lib/optimizer/tests/spec/end-to-end/hello-world/input.html +++ b/lib/optimizer/tests/spec/end-to-end/hello-world/input.html @@ -2,7 +2,8 @@ { "ampUrlPrefix": "/amp", "ampRuntimeVersion": "123456789000000", - "ampUrl": "https://example.com/amp-version.html" + "ampUrl": "https://example.com/amp-version.html", + "geoApiUrl": "/geo" } --> diff --git a/lib/optimizer/tests/spec/transformers/experimental/RewriteAmpUrls/rewrites_host_and_adds_version/expected_output.html b/lib/optimizer/tests/spec/transformers/experimental/RewriteAmpUrls/rewrites_host_and_adds_version/expected_output.html index ca16813d5ff..9c6be4a0b83 100644 --- a/lib/optimizer/tests/spec/transformers/experimental/RewriteAmpUrls/rewrites_host_and_adds_version/expected_output.html +++ b/lib/optimizer/tests/spec/transformers/experimental/RewriteAmpUrls/rewrites_host_and_adds_version/expected_output.html @@ -1,6 +1,7 @@ + @@ -8,7 +9,6 @@ - \ No newline at end of file diff --git a/lib/optimizer/tests/spec/transformers/experimental/RewriteAmpUrls/rewrites_hosts/expected_output.html b/lib/optimizer/tests/spec/transformers/experimental/RewriteAmpUrls/rewrites_hosts/expected_output.html index 08628ad225c..0e977493a51 100644 --- a/lib/optimizer/tests/spec/transformers/experimental/RewriteAmpUrls/rewrites_hosts/expected_output.html +++ b/lib/optimizer/tests/spec/transformers/experimental/RewriteAmpUrls/rewrites_hosts/expected_output.html @@ -1,6 +1,7 @@ + @@ -8,7 +9,6 @@ - \ No newline at end of file diff --git a/lib/optimizer/tests/spec/transformers/valid/MinifyHtml/minifies_inline_JSON/expected_output.html b/lib/optimizer/tests/spec/transformers/valid/MinifyHtml/minifies_inline_JSON/expected_output.html index a84fdc81767..6fc415ea08c 100644 --- a/lib/optimizer/tests/spec/transformers/valid/MinifyHtml/minifies_inline_JSON/expected_output.html +++ b/lib/optimizer/tests/spec/transformers/valid/MinifyHtml/minifies_inline_JSON/expected_output.html @@ -1,4 +1,4 @@ \ No newline at end of file + \ No newline at end of file diff --git a/lib/optimizer/tests/spec/transformers/valid/MinifyHtml/minifies_inline_JSON/input.html b/lib/optimizer/tests/spec/transformers/valid/MinifyHtml/minifies_inline_JSON/input.html index c325cba8bfd..1733d1e8d99 100644 --- a/lib/optimizer/tests/spec/transformers/valid/MinifyHtml/minifies_inline_JSON/input.html +++ b/lib/optimizer/tests/spec/transformers/valid/MinifyHtml/minifies_inline_JSON/input.html @@ -55,6 +55,8 @@ invalid json + + diff --git a/lib/optimizer/tests/spec/transformers/valid/SeparateKeyframes/doesnt_add_tag_with_no_keyframes/expected_output.html b/lib/optimizer/tests/spec/transformers/valid/SeparateKeyframes/doesnt_add_tag_with_no_keyframes/expected_output.html index 7b299d00b67..b1e92150666 100644 --- a/lib/optimizer/tests/spec/transformers/valid/SeparateKeyframes/doesnt_add_tag_with_no_keyframes/expected_output.html +++ b/lib/optimizer/tests/spec/transformers/valid/SeparateKeyframes/doesnt_add_tag_with_no_keyframes/expected_output.html @@ -6,7 +6,7 @@ - +

There shouldn't be a style[amp-keyframes] tag added

diff --git a/lib/optimizer/tests/spec/transformers/valid/SeparateKeyframes/doesnt_move_invalid_keyframes/expected_output.html b/lib/optimizer/tests/spec/transformers/valid/SeparateKeyframes/doesnt_move_invalid_keyframes/expected_output.html index 67d778587ee..ccae5d2f144 100644 --- a/lib/optimizer/tests/spec/transformers/valid/SeparateKeyframes/doesnt_move_invalid_keyframes/expected_output.html +++ b/lib/optimizer/tests/spec/transformers/valid/SeparateKeyframes/doesnt_move_invalid_keyframes/expected_output.html @@ -6,10 +6,10 @@ - +

I should come before style[amp-keyframes]

- + \ No newline at end of file diff --git a/lib/optimizer/tests/spec/transformers/valid/SeparateKeyframes/doesnt_move_media_supports_no_keyframes/expected_output.html b/lib/optimizer/tests/spec/transformers/valid/SeparateKeyframes/doesnt_move_media_supports_no_keyframes/expected_output.html index 120fdc05f16..f8e9d05b360 100644 --- a/lib/optimizer/tests/spec/transformers/valid/SeparateKeyframes/doesnt_move_media_supports_no_keyframes/expected_output.html +++ b/lib/optimizer/tests/spec/transformers/valid/SeparateKeyframes/doesnt_move_media_supports_no_keyframes/expected_output.html @@ -6,10 +6,10 @@ - +

I should come before style[amp-keyframes]

- + \ No newline at end of file diff --git a/lib/optimizer/tests/spec/transformers/valid/SeparateKeyframes/doesnt_move_media_supports_no_keyframes/input.html b/lib/optimizer/tests/spec/transformers/valid/SeparateKeyframes/doesnt_move_media_supports_no_keyframes/input.html index b7338f3a82a..b7db6678833 100644 --- a/lib/optimizer/tests/spec/transformers/valid/SeparateKeyframes/doesnt_move_media_supports_no_keyframes/input.html +++ b/lib/optimizer/tests/spec/transformers/valid/SeparateKeyframes/doesnt_move_media_supports_no_keyframes/input.html @@ -7,7 +7,7 @@ diff --git a/lib/optimizer/tests/spec/transformers/valid/SeparateKeyframes/moves_existing_keyframes_to_end/expected_output.html b/lib/optimizer/tests/spec/transformers/valid/SeparateKeyframes/moves_existing_keyframes_to_end/expected_output.html index 12dc836e01a..dcbf98bd6fd 100644 --- a/lib/optimizer/tests/spec/transformers/valid/SeparateKeyframes/moves_existing_keyframes_to_end/expected_output.html +++ b/lib/optimizer/tests/spec/transformers/valid/SeparateKeyframes/moves_existing_keyframes_to_end/expected_output.html @@ -6,12 +6,12 @@ - +

I should come before style[amp-keyframes]

I should also come before style[amp-keyframes]

- + \ No newline at end of file diff --git a/lib/optimizer/tests/spec/transformers/valid/SeparateKeyframes/moves_existing_keyframes_to_end/input.html b/lib/optimizer/tests/spec/transformers/valid/SeparateKeyframes/moves_existing_keyframes_to_end/input.html index f1f5b6dd6f3..e1e86daf1ec 100644 --- a/lib/optimizer/tests/spec/transformers/valid/SeparateKeyframes/moves_existing_keyframes_to_end/input.html +++ b/lib/optimizer/tests/spec/transformers/valid/SeparateKeyframes/moves_existing_keyframes_to_end/input.html @@ -7,7 +7,7 @@ diff --git a/lib/optimizer/tests/spec/transformers/valid/SeparateKeyframes/moves_keyframes/expected_output.html b/lib/optimizer/tests/spec/transformers/valid/SeparateKeyframes/moves_keyframes/expected_output.html index 84588feb082..6e9697bd601 100644 --- a/lib/optimizer/tests/spec/transformers/valid/SeparateKeyframes/moves_keyframes/expected_output.html +++ b/lib/optimizer/tests/spec/transformers/valid/SeparateKeyframes/moves_keyframes/expected_output.html @@ -6,10 +6,10 @@ - +

I should come before style[amp-keyframes]

- + \ No newline at end of file diff --git a/lib/optimizer/tests/spec/transformers/valid/SeparateKeyframes/moves_keyframes/input.html b/lib/optimizer/tests/spec/transformers/valid/SeparateKeyframes/moves_keyframes/input.html index 56b803164e9..c717e6036de 100644 --- a/lib/optimizer/tests/spec/transformers/valid/SeparateKeyframes/moves_keyframes/input.html +++ b/lib/optimizer/tests/spec/transformers/valid/SeparateKeyframes/moves_keyframes/input.html @@ -7,10 +7,10 @@

I should come before style[amp-keyframes]

- \ No newline at end of file + diff --git a/lib/optimizer/tests/spec/transformers/valid/SeparateKeyframes/moves_keyframes_with_existing/expected_output.html b/lib/optimizer/tests/spec/transformers/valid/SeparateKeyframes/moves_keyframes_with_existing/expected_output.html index d50f970baea..bf3fe641d41 100644 --- a/lib/optimizer/tests/spec/transformers/valid/SeparateKeyframes/moves_keyframes_with_existing/expected_output.html +++ b/lib/optimizer/tests/spec/transformers/valid/SeparateKeyframes/moves_keyframes_with_existing/expected_output.html @@ -6,11 +6,11 @@ - +

I should come before style[amp-keyframes]

- + \ No newline at end of file diff --git a/lib/optimizer/tests/spec/transformers/valid/ServerSideRendering/boilerplate_not_removed_when_amp_experiment_present/input.html /input.html b/lib/optimizer/tests/spec/transformers/valid/ServerSideRendering/boilerplate_not_removed_when_amp_experiment_present/input.html /input.html deleted file mode 100644 index d59ed16f949..00000000000 --- a/lib/optimizer/tests/spec/transformers/valid/ServerSideRendering/boilerplate_not_removed_when_amp_experiment_present/input.html /input.html +++ /dev/null @@ -1,25 +0,0 @@ - - - - - - - - - - - - - -