Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically mark GA4 scripts as being PX-verified #7290

Merged
merged 36 commits into from
Oct 27, 2022
Merged

Automatically mark GA4 scripts as being PX-verified #7290

merged 36 commits into from
Oct 27, 2022

Commits on Oct 10, 2022

  1. Add GA4 scripts sanitizer

    @thelovekesh
    thelovekesh committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    c8a5ed4 View commit details
    Browse the repository at this point in the history

  2. Add AMP_GTag_Script_Sanitizer class in sanitizers

    @thelovekesh
    thelovekesh committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    91e57b9 View commit details
    Browse the repository at this point in the history

  3. Add sandboxing options in the Option interface

    @thelovekesh
    thelovekesh committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    fa5bc0f View commit details
    Browse the repository at this point in the history

  4. Update sandboxing options to be used from Option interface

    @thelovekesh
    thelovekesh committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    86cdc26 View commit details
    Browse the repository at this point in the history

  5. Update sandboxing options

    @thelovekesh
    thelovekesh committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    c8b6462 View commit details
    Browse the repository at this point in the history

  6. Update tests to use sandboxing level from Option interface

    @thelovekesh
    thelovekesh committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    59911c2 View commit details
    Browse the repository at this point in the history

  7. Update sandboxing service tests

    @thelovekesh
    thelovekesh committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    a03dd35 View commit details
    Browse the repository at this point in the history

  8. Update xpath to query gtag script tags more accurately

    @thelovekesh
    thelovekesh committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    a62b010 View commit details
    Browse the repository at this point in the history

  9. Add test cases for AMP_GTag_Script_Sanitizer class

    @thelovekesh
    thelovekesh committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    090b84c View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2022

  1. Merge branch 'develop' into add/GA4-scripts-sanitizer

    @thelovekesh
    thelovekesh authored Oct 19, 2022
    Configuration menu
    Copy the full SHA
    b6d5bae View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2022

  1. Update comment for included AMP_GTag_Script_Sanitizer class in sani… 

    …tizers

Co-authored-by: Weston Ruter <westonruter@google.com>
    @thelovekesh @westonruter
    thelovekesh and westonruter authored Oct 21, 2022
    Configuration menu
    Copy the full SHA
    7c1cd64 View commit details
    Browse the repository at this point in the history

  2. Update xpath query for Google tag scripts 

    Co-authored-by: Weston Ruter <westonruter@google.com>
    @thelovekesh @westonruter
    thelovekesh and westonruter authored Oct 21, 2022
    Configuration menu
    Copy the full SHA
    b88130f View commit details
    Browse the repository at this point in the history

  3. Add deprecated tag on sandboxing service option keys constants

    @thelovekesh
    thelovekesh committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    97b1053 View commit details
    Browse the repository at this point in the history

  4. Add space after class declaration

    @thelovekesh
    thelovekesh committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    c47c831 View commit details
    Browse the repository at this point in the history

  5. Remove tear_down fixture as WordPress tests rollback the current data… 

    …base transaction after each test run
    @thelovekesh
    thelovekesh committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    60a5ce8 View commit details
    Browse the repository at this point in the history

  6. Remove setup fixture

    @thelovekesh
    thelovekesh committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    f6ba0a8 View commit details
    Browse the repository at this point in the history

  7. Add constant to store gtag html markup

    @thelovekesh
    thelovekesh committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    5032593 View commit details
    Browse the repository at this point in the history

  8. Update xpath query to be more specific

    @thelovekesh
    thelovekesh committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    8d34d45 View commit details
    Browse the repository at this point in the history

  9. Move tests to dataProvider

    @thelovekesh
    thelovekesh committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    b28e9d3 View commit details
    Browse the repository at this point in the history

  10. Add more script tags to make sure any non-gtag script tags are always… 

    … not PX-verified
    @thelovekesh
    thelovekesh committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    357f4cc View commit details
    Browse the repository at this point in the history

  11. Merge branch 'develop' into add/GA4-scripts-sanitizer

    @thelovekesh
    thelovekesh committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    74a3f9f View commit details
    Browse the repository at this point in the history

  12. Remove unused method 

    Co-authored-by: Weston Ruter <westonruter@google.com>
    @thelovekesh @westonruter
    thelovekesh and westonruter authored Oct 21, 2022
    Configuration menu
    Copy the full SHA
    8d13af0 View commit details
    Browse the repository at this point in the history

  13. Add @return tag in dataProvider 

    Co-authored-by: Weston Ruter <westonruter@google.com>
    @thelovekesh @westonruter
    thelovekesh and westonruter authored Oct 21, 2022
    Configuration menu
    Copy the full SHA
    a1e9b6e View commit details
    Browse the repository at this point in the history

  14. Remove unused properties 

    Co-authored-by: Weston Ruter <westonruter@google.com>
    @thelovekesh @westonruter
    thelovekesh and westonruter authored Oct 21, 2022
    Configuration menu
    Copy the full SHA
    3e7d2dc View commit details
    Browse the repository at this point in the history

  15. Add more script tags for clear test cases 

    Co-authored-by: Weston Ruter <westonruter@google.com>
    @thelovekesh @westonruter
    thelovekesh and westonruter authored Oct 21, 2022
    Configuration menu
    Copy the full SHA
    0aca46e View commit details
    Browse the repository at this point in the history

  16. Add assertions for scripts other then gtag scripts

    @thelovekesh
    thelovekesh committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    feb3910 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2022

  1. Add inline gtag event attrs as px verified attrs

    @thelovekesh
    thelovekesh committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    df3ee7b View commit details
    Browse the repository at this point in the history

  2. Add test cases for px verified attrs with inline gtag event

    @thelovekesh
    thelovekesh committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    1762657 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into add/GA4-scripts-sanitizer

    @thelovekesh
    thelovekesh authored Oct 25, 2022
    Configuration menu
    Copy the full SHA
    ca84712 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2022

  1. Update xpath query to use starts-with while matching on* events 

    Co-authored-by: Weston Ruter <westonruter@google.com>
    @thelovekesh @westonruter
    thelovekesh and westonruter authored Oct 26, 2022
    Configuration menu
    Copy the full SHA
    5b0f6a4 View commit details
    Browse the repository at this point in the history

  2. Update assertion method for finding a string match 

    Co-authored-by: Weston Ruter <westonruter@google.com>
    @thelovekesh @westonruter
    thelovekesh and westonruter authored Oct 26, 2022
    Configuration menu
    Copy the full SHA
    359bcc8 View commit details
    Browse the repository at this point in the history

  3. Add early return if no gtag script is present

    @thelovekesh
    thelovekesh committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    e0a6906 View commit details
    Browse the repository at this point in the history

  4. Update xpath query in tests

    @thelovekesh
    thelovekesh committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    6bec836 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2022

  1. Add test case when no gtag script is present in document

    @thelovekesh
    thelovekesh committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    d4b4bfd View commit details
    Browse the repository at this point in the history

  2. qMerge branch 'develop' into add/GA4-scripts-sanitizer

    @thelovekesh
    thelovekesh committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    e50ee5b View commit details
    Browse the repository at this point in the history

  3. Move up check for DOMNodeList

    @westonruter
    westonruter authored Oct 27, 2022
    Configuration menu
    Copy the full SHA
    aeacc33 View commit details
    Browse the repository at this point in the history