Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMP4Email: Support autocomplete #24881

Closed
Sitanderkumar opened this issue Oct 3, 2019 · 7 comments · Fixed by #34848
Closed

AMP4Email: Support autocomplete #24881

Sitanderkumar opened this issue Oct 3, 2019 · 7 comments · Fixed by #34848

Comments

@Sitanderkumar
Copy link

Sitanderkumar commented Oct 3, 2019

I am trying to create a search widget in AMP email, below is the code.
but i am getting in promise error in the console when clicking on the submit button.

@and is there any way to use autosuggest for from and to the field.

<form method="post" action-xhr="https://m.cheapoair.com/remotesearchhandler.aspx"   id="widget-form"  id="widget-form" >
<!-- <span [text]="'formDataVar.originCityCode = ' + formDataVar.originCityCode + 'formDataVar.originCity = ' + formDataVar.originCity  + 'formDataVar.originquery = ' + formDataVar.originquery "></span> -->
	<input type="search" name="from" id="from" class="search-box" required="" pattern="[A-Za-z\s]+">
	<input type="search" name="to" id="to" class="search-box" required="" pattern="[A-Za-z\s]+">
	<input type="submit" value="Search" id="search"> </div>
</form>

@nainar @cvializ

@nainar
Copy link
Contributor

nainar commented Oct 4, 2019

Hi, for autocomplete we suggest using amp-autocomplete: https://amp.dev/documentation/examples/components/amp-autocomplete/

@Sitanderkumar
Copy link
Author

Sitanderkumar commented Oct 4, 2019

Thanks Nainar,

but this auto-suggest not acceptable by amp4emai.

is there any other way to use autosuggest in AMP email.

@Sitanderkumar
Copy link
Author

a part for it, as i already mentioned above that form that i am trying to create in email is giving me error when click on submit button. (find code above)

image

@dreamofabear dreamofabear changed the title in promise error during submitting form in amp email AMP4Email: Support autocomplete Oct 4, 2019
@sparhami
Copy link

sparhami commented Oct 7, 2019

The amp-autocomplete is not yet valid in the email format. I know @caroqliu is working on some autocomplete functionality for emails. t I think for the basic component, it is only a matter of the email format working group being comfortable with allowing the component in the current state.

@stale
Copy link

stale bot commented Apr 11, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Inactive for one year or more label Apr 11, 2021
@ggaabe
Copy link

ggaabe commented Apr 14, 2021

Is there a spec for which native autocomplete attributes will be supported in email? It seems certain ones fail while others work fine.

@stale stale bot removed the Stale Inactive for one year or more label Apr 14, 2021
@caroqliu
Copy link
Contributor

Is there a spec for which native autocomplete attributes will be supported in email? It seems certain ones fail while others work fine.

All attributes listed in the email-view of amp.dev should work: https://amp.dev/documentation/components/amp-autocomplete/?format=email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants