Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pandas Column Stats Extractor error cast type: str to float #1487

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

kenny-shopback
Copy link
Contributor

Summary of Changes

Force STAT_MAPPINGS: Min, Max, Range: from data type float to str

Tests

  1. tested with column have data type: int, float, datetime (I did not face error: ValueError: could not convert string to float: '2018-04-30 17:35:25' with data type datetime anymore.

Documentation

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

@kenny-shopback kenny-shopback requested a review from a team as a code owner September 10, 2021 12:08
@boring-cyborg boring-cyborg bot added the area:databuilder From databuilder folder label Sep 10, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Sep 10, 2021

Congratulations on your first Pull Request and welcome to Amundsen community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/amundsen-io/amundsen/blob/main/CONTRIBUTING.md)

@kenny-shopback kenny-shopback changed the title fix Pandas Column Stats Extractor error cast type: str to float fix Fixed Pandas Column Stats Extractor error cast type: str to float Sep 10, 2021
@kenny-shopback kenny-shopback changed the title fix Fixed Pandas Column Stats Extractor error cast type: str to float fix – Fixes Pandas Column Stats Extractor error cast type: str to float Sep 10, 2021
@kenny-shopback kenny-shopback changed the title fix – Fixes Pandas Column Stats Extractor error cast type: str to float fix: Pandas Column Stats Extractor error cast type: str to float Sep 10, 2021
@mgorsk1
Copy link
Contributor

mgorsk1 commented Sep 10, 2021

thanks! please remember to complete Github DCO so I can merge

Signed-off-by: Kenny.Ta <kenny.ta@shopback.com>
@kenny-shopback
Copy link
Contributor Author

done, @mgorsk1

@mgorsk1 mgorsk1 merged commit ed20ce0 into amundsen-io:main Sep 10, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Sep 10, 2021

Awesome work, congrats on your first merged pull request!

ozandogrultan pushed a commit to deliveryhero/amundsen that referenced this pull request Apr 28, 2022
Signed-off-by: Ozan Dogrultan <ozan.dogrultan@deliveryhero.com>
zacr pushed a commit to SaltIO/amundsen that referenced this pull request May 13, 2022
hansadriaans pushed a commit to DataChefHQ/amundsen that referenced this pull request Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:databuilder From databuilder folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants