feat: added TableStats model #1503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
boring-cyborg
bot
added
area:databuilder
allisonsuarez
requested review from
dechoma,
dorianj,
feng-tao,
jinhyukchang,
mgorsk1,
sewardgw,
verdan,
youngyjd and
a team
as code owners
youngyjd
reviewed
Sep 24, 2021
| @@ -94,7 +202,7 @@ def _create_node_iterator(self) -> Iterator[GraphNode]: | |||
| """ | |||
| node = GraphNode( | |||
| key=self.get_table_stat_model_key(), | |||
There was a problem hiding this comment.
Let's rename this function to get_column_stat_model_key?
youngyjd
reviewed
Sep 24, 2021
| RESOURCE_STAT_RELATION_TYPE = 'STAT' | ||
|
|
||
|
|
||
| class TableStats(GraphSerializable, TableSerializable): |
There was a problem hiding this comment.
What are the stats that we want to surface? There are some metadata on the left side panel in table details page, for example, total number of rows, etc. Will some of the metadata be moved to this stats model?
There was a problem hiding this comment.
As of right now we are indexing usage stats like dau, query count, and service specific usage like for airflow, flyte, etc. In the future however we could use this to index stats about the data in the table as well, similar to how we already do for columns.
dkunitsk
reviewed
Sep 24, 2021
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
…mundsen into asm-stat-table-databuilder
amommendes
pushed a commit
to amommendes/amundsen
that referenced
this pull request
Jan 21, 2022
* feat: added TableStats model Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * ... Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * implemented feedback Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * updated unit test Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> Signed-off-by: Amom Mendes <amommendes@hotmail.com>
ozandogrultan
pushed a commit
to deliveryhero/amundsen
that referenced
this pull request
Apr 28, 2022
* feat: added TableStats model Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * ... Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * implemented feedback Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * updated unit test Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> Signed-off-by: Ozan Dogrultan <ozan.dogrultan@deliveryhero.com>
zacr
pushed a commit
to SaltIO/amundsen
that referenced
this pull request
May 13, 2022
* feat: added TableStats model Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * ... Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * implemented feedback Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * updated unit test Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
hansadriaans
pushed a commit
to DataChefHQ/amundsen
that referenced
this pull request
Jun 30, 2022
* feat: added TableStats model Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * ... Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * implemented feedback Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * updated unit test Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Allison Suarez Miranda asuarezmiranda@lyft.com
Summary of Changes
Added TableStats model which allows adding Stats directly to table nodes rather than only to table columns.
Tests
Documentation
CheckList
Make sure you have checked all steps below to ensure a timely review.