Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin rds package version in databuilder #1520

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

xuan616
Copy link
Member

@xuan616 xuan616 commented Oct 6, 2021

Summary of Changes

  • Pin rds package version to 0.0.5 in databuilder to make it consistent with metadata_service
  • Bump databuilder version to 6.2.1
  • Removed the stale 'ToDo' comment in sample_data_loader_mysql.py

Tests

No real code change

N/A

Documentation

N/A

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

Signed-off-by: xuans <xuan_shen@outlook.com>
@feng-tao feng-tao merged commit dfe0b4f into amundsen-io:main Oct 6, 2021
amommendes pushed a commit to amommendes/amundsen that referenced this pull request Jan 21, 2022
Signed-off-by: xuans <xuan_shen@outlook.com>
Signed-off-by: Amom Mendes <amommendes@hotmail.com>
ozandogrultan pushed a commit to deliveryhero/amundsen that referenced this pull request Apr 28, 2022
Signed-off-by: xuans <xuan_shen@outlook.com>
Signed-off-by: Ozan Dogrultan <ozan.dogrultan@deliveryhero.com>
zacr pushed a commit to SaltIO/amundsen that referenced this pull request May 13, 2022
Signed-off-by: xuans <xuan_shen@outlook.com>
hansadriaans pushed a commit to DataChefHQ/amundsen that referenced this pull request Jun 30, 2022
Signed-off-by: xuans <xuan_shen@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:databuilder From databuilder folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants