Fix: Column Index should not use sort index #1526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Won <dwon@lyft.com>
danwom
requested review from
allisonsuarez,
dorianj,
feng-tao,
Golodhros,
mgorsk1,
sewardgw,
ttannis,
verdan and
youngyjd
as code owners
Golodhros
approved these changes
Oct 11, 2021
|
deployed this in our environment and it's looking good. thanks!!! |
|
Thanks @danwom it fixed the issue! |
amommendes
pushed a commit
to amommendes/amundsen
that referenced
this pull request
Jan 21, 2022
* fix the "fix" for column index Signed-off-by: Daniel Won <dwon@lyft.com> Signed-off-by: Amom Mendes <amommendes@hotmail.com>
ozandogrultan
pushed a commit
to deliveryhero/amundsen
that referenced
this pull request
Apr 28, 2022
* fix the "fix" for column index Signed-off-by: Daniel Won <dwon@lyft.com> Signed-off-by: Ozan Dogrultan <ozan.dogrultan@deliveryhero.com>
zacr
pushed a commit
to SaltIO/amundsen
that referenced
this pull request
May 13, 2022
* fix the "fix" for column index Signed-off-by: Daniel Won <dwon@lyft.com>
hansadriaans
pushed a commit
to DataChefHQ/amundsen
that referenced
this pull request
Jun 30, 2022
* fix the "fix" for column index Signed-off-by: Daniel Won <dwon@lyft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Addresses previous fix that uses sort_index as the column index. sort_index is not reliable.
Tests
Documentation
CheckList
Make sure you have checked all steps below to ensure a timely review.