fix(CMSIS): MAX32657 bring up #1285
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-gillespie
changed the title
github-actions
bot
added
the
Register Change
|
/clang-format-run |
kevin-gillespie
changed the title
sihyung-maxim
requested changes
Dec 12, 2024
Comment on lines
+271
to
+272
| #define MXC_F_UART_REVB_INT_FL_TX_OR_POS 5 /**< INT_FL_TX_OR Position */ | ||
| #define MXC_F_UART_REVB_INT_FL_TX_OR ((uint32_t)(0x1UL << MXC_F_UART_REVB_INT_FL_TX_OR_POS)) /**< INT_FL_TX_OR Mask */ |
There was a problem hiding this comment.
Hmm, I guess I didn't regenerate the UART RevB register files after adding the UART one byte remaining interrupt field. The SVD and the ME30 user guide use the TX_OB name:
#define MXC_F_UART_REVB_INT_EN_TX_OB_POS 5 /**< INT_EN_TX_OB Position */
#define MXC_F_UART_REVB_INT_EN_TX_OB ((uint32_t)(0x1UL << MXC_F_UART_REVB_INT_EN_TX_OB_POS)) /**< INT_EN_TX_OB Mask */
#define MXC_F_UART_REVB_INT_FL_TX_OB_POS 5 /**< INT_FL_TX_OB Position */
#define MXC_F_UART_REVB_INT_FL_TX_OB ((uint32_t)(0x1UL << MXC_F_UART_REVB_INT_FL_TX_OB_POS)) /**< INT_FL_TX_OB Mask */
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevents unaligned memory access. Hard fault experienced without this build flag when using memcpy.
Adds UART one byte remaining interrupt.
Adding WLP_Bench board folder.
Checklist Before Requesting Review