Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MiscDrivers,PeriphDrivers): Fix TMR and TFT build errors for MAX32570 #901

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

sihyung-maxim
Copy link
Contributor

@sihyung-maxim sihyung-maxim commented Feb 1, 2024

Description

Related to issue #900

This PR fixes the build errors for MAX32570A as a result of the changes made for the MAX32572 and MAX32570B.

The previous changes made in tmr.h were directed towards the MAX32570B, but did not take into account of the existing MAX32570A naming convention.

The TFT drivers used the incorrect SPI definitions for the MAX32570A.

Checklist Before Requesting Review

  • PR Title follows correct guidelines.
  • Description of changes and all other relevant information.
  • (Optional) Link any related GitHub issues using a keyword
  • (Optional) Provide info on any relevant functional testing/validation. For API changes or significant features, this is not optional.

@github-actions github-actions bot added the MAX32570 Related to the MAX32570 (ME13) label Feb 1, 2024
@sihyung-maxim
Copy link
Contributor Author

/clang-format-run

@Jake-Carter Jake-Carter merged commit f9c0dd1 into main Feb 1, 2024
9 checks passed
@Jake-Carter Jake-Carter deleted the fix/tmr_spi_me13 branch February 1, 2024 18:51
EricB-ADI pushed a commit that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MAX32570 Related to the MAX32570 (ME13)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants