Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: hotfix add use_smartconnect #55

Closed
wants to merge 1 commit into from
Closed

Conversation

gastmaier
Copy link
Contributor

Sets default value to use_smartconnenct.
Previously I thought it would take from somewhere else for every tb, but that preconception is false since #54 is failing rebased to main.

Signed-off-by: Jorge Marques <jorge.marques@analog.com>
Copy link
Contributor

@IstvanZsSzekely IstvanZsSzekely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked various projects to see why are they built with the latest changes and the DMA_SG project not. I dug a bit in the recent modifications in the HDL infrastructure updates as well, and I found that if the FPGA is set to be a 7-series one, then the HDL and Testbench projects are automatically built with Axi-Interconnect. In the DMA_SG case, the project was created using a 7-series FPGA, so the script was automatically waiting for old scripting commands. I request a change on the DMA_SG PR to solve this issue.

@IstvanZsSzekely
Copy link
Contributor

I'll put this PR in draft, up until we get an answer from Xilinx to see if the Smart Connect can be used to connect 16+ modules to it in low-area mode. Currently this is not working in the design, but according to the docs, it should.

@IstvanZsSzekely IstvanZsSzekely marked this pull request as draft February 12, 2024 12:18
@IstvanZsSzekely
Copy link
Contributor

The suggested change for the DMA_SG_PR worked and the Smart Connect cannot be used with 16+ slave interfaces due to some environment limitations. A PR has been created to address the 16+ slave interface issue for the ADRV9009 and future projects.
This PR is hence closed.

@gastmaier gastmaier deleted the smartconnect_hotfix branch October 17, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants