Add OS codename dataset #433
Merged
+369
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wagoodman
force-pushed
the
add-codename-helpers
branch
from
4703b7a
to
60d420b
Compare
wagoodman
force-pushed
the
add-codename-helpers
branch
from
60d420b
to
6bd245d
Compare
wagoodman
force-pushed
the
add-codename-helpers
branch
from
6bd245d
to
dd9b37e
Compare
kzantow
approved these changes
Nov 21, 2024
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
wagoodman
force-pushed
the
add-codename-helpers
branch
from
dd9b37e
to
833c82f
Compare
|
force pushed to rebase after #432 landed |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v6 we'll be allowing for searching by OS codename. This data isn't always available from upstream vunnel providers, so instead, we'll be injecting it at the last mile when writing records. This PR is only concerned with how the data is generated into the codebase, the workflow responsible for updating it, and the helper function to use the generated data to find codenames for OS names and versions (for example, given "ubuntu 20.04" return "focal").
Example workflow run that would create the PR if there were code updates https://github.com/anchore/grype-db/actions/runs/11957163261/job/33333641284