Wrong slug name in settings #57
Conversation
|
Hi Jeff, I really appreciate the contribution to the project, but I am afraid I won't be merging it. Basically, it already has been fixed in the development branch but that branch can't be merged because I am not the owner and pylint is being a major pain. The owner of the repo has been very busy in order to, from what I can gather, save the world from an underground league of supervillians. So this repo is kind of unmaintained because I don't really want to make sweeping chances to master without him agreeing to it. So long story short, I recommend checking out my fork (ValentijnvdBeek/clay) since that one is maintained and up to date. Anyways enough of my self indulgent prattle, let's talk about the commit. The code change pretty minor and the style is good so I would merge this. The commit style is fine but I personally would I have liked it if you squashed the two commits together and changed the commit message to "Fix #56: Wrong slug name in settings". Prefixing fix #bugid will reference it on the bugreport and automatically close it when it is merged. Outside of that you could have added your name to the README and CONTRIBUTERS but the chance isn't big enough to badger you over it. Anyways, the commit is good but it has some small style issues. So I would have merged it if there weren't some issues in the project. Thanks again for the fix! Valentijn |
No description provided.