From a549f24cd1198bfe8dac640680bd8801f858fc7d Mon Sep 17 00:00:00 2001
From: Andrea Bedini <andrea.bedini@tweag.io>
Date: Wed, 10 Jul 2024 14:23:35 +0800
Subject: [PATCH] ci(validate.yml): Allow workflow_dispatch with no allow-newer
 or constraints

---
 .github/workflows/validate.yml | 16 ++++++++++------
 CONTRIBUTING.md                |  2 +-
 2 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/validate.yml b/.github/workflows/validate.yml
index 600e8e982bb..62b446b2293 100644
--- a/.github/workflows/validate.yml
+++ b/.github/workflows/validate.yml
@@ -31,11 +31,11 @@ on:
     inputs:
       allow-newer:
         description: allow-newer line
-        required: true
+        required: false
         type: string
       constraints:
         description: constraints line
-        required: true
+        required: false
         type: string
 
 env:
@@ -92,11 +92,15 @@ jobs:
       - uses: actions/checkout@v4
 
       # See https://github.com/haskell/cabal/blob/master/CONTRIBUTING.md#hackage-revisions
-      - name: Manually supplied constraints/allow-newer
-        if: github.event_name == 'workflow_dispatch'
+      - name: Add manually supplied allow-newer
+        if: github.event_name == 'workflow_dispatch' && github.event.inputs.allow-newer != ''
         run: |
-          echo "allow-newer: ${ALLOWNEWER}"  >> cabal.validate.project
-          echo "constraints: ${CONSTRAINTS}" >> cabal.validate.project
+          echo "allow-newer: ${{ github.event.inputs.allow-newer }}" >> cabal.validate.project
+
+      - name: Add manually supplied constraints
+        if: github.event_name == 'workflow_dispatch' && github.event.inputs.constraints != ''
+        run: |
+          echo "constraints: ${{ github.event.inputs.constraints }}" >> cabal.validate.project
 
       - uses: haskell-actions/setup@v2
         id: setup-haskell
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index f9d24a6e113..c6944eb1227 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -429,7 +429,7 @@ it, someone with enough permissions needs to go on the
 [Validate workflow page](https://github.com/haskell/cabal/actions/workflows/validate.yml)
 and dispatch it manually by clicking "Run workflow".
 
-Running workflow manually as discussed above requires you to supply two inputs:
+Running workflow manually as discussed above allows you to supply two inputs:
 
 > allow-newer line
 > constraints line