Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config backup via new api endpoint (#51) #51

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

jan-win1993
Copy link
Contributor

  • Added new command "configbackup" which uses the newer API-endpoint (in OPNsense core) to download config bacup
  • Did not modify the old "apibackup" command
  • Added remarks to the help pages of the "apibackup" and "configbackup" commands

@jan-win1993
Copy link
Contributor Author

With the release of OPNsense version 24.1 the plugin "os-api-backup" was discontinued and therefore the old API-endpoint for configuration backups can't be used anymore.
I've added a new command "configbackup" which uses the newer API-endpoint (which resides in the OPNsense core library) to download the configuration backup.
To ensure backwards compatibility I did not modify the old "apibackup" command and added some remarks to the help pages of the "apibackup" and "configbackup" commands.
The unit test did run successfully in isolation:

opnsense_cli/tests/commands/core/test_configbackup.py::TestApibackupCommands::test_download PASSED  [100%]                                    

Best regards,
Jan.

@andreas-stuerz andreas-stuerz merged commit e4c104f into andreas-stuerz:main Mar 18, 2024
1 check passed
@andreas-stuerz andreas-stuerz added the enhancement New feature or request label Mar 18, 2024
@jan-win1993
Copy link
Contributor Author

If possible a new release would be very nice :)
Thanks in advance !
Best regards,
Jan.

@andreas-stuerz
Copy link
Owner

Hi Jan,

the changes will be included in the 2.0 release which is comming soon.

Best regards,
Andreas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants