From 76b899a345e5cdfe3367619920a4ab7513024c0b Mon Sep 17 00:00:00 2001 From: Andreas Gerstmayr Date: Sun, 16 Jul 2023 15:23:50 +0200 Subject: [PATCH] catch errors in script function --- fava_dashboards/static/dashboard.js | 23 ++++++++++++++++++++--- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/fava_dashboards/static/dashboard.js b/fava_dashboards/static/dashboard.js index 638ee05..1d1f652 100644 --- a/fava_dashboards/static/dashboard.js +++ b/fava_dashboards/static/dashboard.js @@ -57,11 +57,21 @@ class Panel { } static html(ledger, panel, elem) { - elem.innerHTML = Panel.runScript(ledger, panel); + try { + elem.innerHTML = Panel.runScript(ledger, panel); + } catch (e) { + elem.innerHTML = e; + } } static echarts(ledger, panel, elem) { - const options = Panel.runScript(ledger, panel); + let options; + try { + options = Panel.runScript(ledger, panel); + } catch (e) { + elem.innerHTML = e; + return; + } const chart = echarts.init(elem); if (options.onClick) { @@ -76,7 +86,14 @@ class Panel { } static d3_sankey(ledger, panel, elem) { - const options = Panel.runScript(ledger, panel); + let options; + try { + options = Panel.runScript(ledger, panel); + } catch (e) { + elem.innerHTML = e; + return; + } + render_d3sankey(elem, options); }