From c1821ea58168685a2351c4b03a1f867642448a46 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= Date: Tue, 5 Mar 2019 15:25:47 +0200 Subject: [PATCH] tools/gdbsx: fix -Wstringop-truncation warning MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit gcc-8 complains: gx_main.c: In function 'prepare_stop_reply': gx_main.c:385:9: error: 'strncpy' output truncated before terminating nul copying 6 bytes from a string of the same length [-Werror=stringop-truncation] strncpy(buf, "watch:", 6); ^~~~~~~~~~~~~~~~~~~~~~~~~ Since terminating '\0' isn't needed here at all, switch to memcpy. (cherry picked from commit 7f601f7c341c80d554615556d60e3b8ed1e5ad4f) Cherry-pick-repository: https://xenbits.xen.org/gitweb/?p=xen.git Issue: ALB-3594 Signed-off-by: Marek Marczykowski-Górecki --- tools/debugger/gdbsx/gx/gx_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/debugger/gdbsx/gx/gx_main.c b/tools/debugger/gdbsx/gx/gx_main.c index a908c45e1d..6dfa501145 100644 --- a/tools/debugger/gdbsx/gx/gx_main.c +++ b/tools/debugger/gdbsx/gx/gx_main.c @@ -382,7 +382,7 @@ prepare_stop_reply(enum target_signal sig, char *buf, vcpuid_t vcpu) /* TBD: check if we stopped because of watchpoint */ if (watchpoint_stop()) { - strncpy(buf, "watch:", 6); + memcpy(buf, "watch:", 6); buf += 6; /* TBD: **/ }