Skip to content

Commit

Permalink
cmd: zed: rc: drop "should be owned by root and 0600"
Browse files Browse the repository at this point in the history
It doesn't matter, 0600 are Weird Permissions, and it's even weirder to
spec them for no reason ‒ it's perfectly fine if it's the usual 0:0 644,
or literally anything else, so long as unprivileged users can't edit it
(which (a) 644 accomplishes and (b) is at the administrator's
 discretion, it's not unheard of to have adm users and having it
 be 664 in that case is just as good; it's not our place to say)

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#12544
Closes openzfs#13276
  • Loading branch information
nabijaczleweli authored and andrewc12 committed Sep 23, 2022
1 parent cf66979 commit b6f9068
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
1 change: 0 additions & 1 deletion cmd/zed/zed.d/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ install-data-hook:
-L "$(DESTDIR)$(zedconfdir)/$${f}" || \
ln -s "$(zedexecdir)/$${f}" "$(DESTDIR)$(zedconfdir)"; \
done
chmod 0600 "$(DESTDIR)$(zedconfdir)/zed.rc"

# False positive: 1>&"${ZED_FLOCK_FD}" looks suspiciously similar to a >&filename bash extension
CHECKBASHISMS_IGNORE = -e 'should be >word 2>&1' -e '&"$${ZED_FLOCK_FD}"'
4 changes: 1 addition & 3 deletions cmd/zed/zed.d/zed.rc
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
##
# zed.rc
#
# This file should be owned by root and permissioned 0600.
# zed.rc – ZEDLET configuration.
##
# shellcheck disable=SC2034

Expand Down

0 comments on commit b6f9068

Please sign in to comment.