From c8884e465fdc479127750f9aee6615975491fc23 Mon Sep 17 00:00:00 2001 From: Richard Yao Date: Thu, 20 Oct 2022 12:12:21 -0400 Subject: [PATCH] Fix multiple definitions of struct mount_attr on recent glibc versions The ifdef used would never work because the CPP is not aware of C structure definitions. Rather than use an autotools check, we can just use a nameless structure that we typedef to mount_attr_t. This is a Linux kernel interface, which means that it is stable and this is fine to do. Reviewed-by: Brian Behlendorf Reviewed-by: Youzhong Yang Signed-off-by: Richard Yao Closes #14057 Closes #14058 --- tests/zfs-tests/cmd/idmap_util.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/tests/zfs-tests/cmd/idmap_util.c b/tests/zfs-tests/cmd/idmap_util.c index a9731f00dbc0..143cd4db67be 100644 --- a/tests/zfs-tests/cmd/idmap_util.c +++ b/tests/zfs-tests/cmd/idmap_util.c @@ -99,18 +99,16 @@ #define AT_RECURSIVE 0x8000 #endif -#ifndef mount_attr -struct mount_attr { +typedef struct { __u64 attr_set; __u64 attr_clr; __u64 propagation; __u64 userns_fd; -}; -#endif +} mount_attr_t; static inline int sys_mount_setattr(int dfd, const char *path, unsigned int flags, - struct mount_attr *attr, size_t size) + mount_attr_t *attr, size_t size) { return (syscall(__NR_mount_setattr, dfd, path, flags, attr, size)); } @@ -528,7 +526,7 @@ is_idmap_supported(char *path) list_t head; int ret; int tree_fd = -EBADF, path_fd = -EBADF; - struct mount_attr attr = { + mount_attr_t attr = { .attr_set = MOUNT_ATTR_IDMAP, .userns_fd = -EBADF, }; @@ -634,7 +632,7 @@ do_idmap_mount(list_t *idmap, char *source, char *target, int flags) { int ret; int tree_fd = -EBADF, source_fd = -EBADF; - struct mount_attr attr = { + mount_attr_t attr = { .attr_set = MOUNT_ATTR_IDMAP, .userns_fd = -EBADF, };