From 33c4f609f6493ce7a0b7bfe698d9fa8c00bf5b27 Mon Sep 17 00:00:00 2001
From: yongsuk44 <rlarladyd@gmail.com>
Date: Mon, 25 Nov 2024 21:03:33 +0900
Subject: [PATCH 1/2] Optimize padding calculation by removing
 BoxWithConstraints

---
 .../com/example/jetcaster/ui/home/Home.kt     | 58 +++++++++----------
 1 file changed, 27 insertions(+), 31 deletions(-)

diff --git a/Jetcaster/mobile/src/main/java/com/example/jetcaster/ui/home/Home.kt b/Jetcaster/mobile/src/main/java/com/example/jetcaster/ui/home/Home.kt
index a3230edfe..2bd59e811 100644
--- a/Jetcaster/mobile/src/main/java/com/example/jetcaster/ui/home/Home.kt
+++ b/Jetcaster/mobile/src/main/java/com/example/jetcaster/ui/home/Home.kt
@@ -22,6 +22,7 @@ import androidx.activity.compose.BackHandler
 import androidx.compose.foundation.ExperimentalFoundationApi
 import androidx.compose.foundation.background
 import androidx.compose.foundation.clickable
+import androidx.compose.foundation.gestures.snapping.SnapPosition
 import androidx.compose.foundation.layout.Arrangement
 import androidx.compose.foundation.layout.Box
 import androidx.compose.foundation.layout.BoxScope
@@ -93,6 +94,7 @@ import androidx.compose.ui.Modifier
 import androidx.compose.ui.draw.clip
 import androidx.compose.ui.geometry.Rect
 import androidx.compose.ui.graphics.Color
+import androidx.compose.ui.platform.LocalConfiguration
 import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.text.style.TextOverflow
 import androidx.compose.ui.tooling.preview.Preview
@@ -664,37 +666,31 @@ private fun FollowedPodcasts(
     navigateToPodcastDetails: (PodcastInfo) -> Unit,
     modifier: Modifier = Modifier,
 ) {
-    // TODO: Using BoxWithConstraints is not quite performant since it requires 2 passes to compute
-    // the content padding. This should be revisited once a carousel component is available.
-    // Alternatively, version 1.7.0-alpha05 of Compose Foundation supports `snapPosition`
-    // which solves this problem and avoids this calculation altogether. Once 1.7.0 is
-    // stable, this implementation can be updated.
-    BoxWithConstraints(
-        modifier = modifier.background(Color.Transparent)
-    ) {
-        val horizontalPadding = (this.maxWidth - FEATURED_PODCAST_IMAGE_SIZE_DP) / 2
-        HorizontalPager(
-            state = pagerState,
-            contentPadding = PaddingValues(
-                horizontal = horizontalPadding,
-                vertical = 16.dp,
-            ),
-            pageSpacing = 24.dp,
-            pageSize = PageSize.Fixed(FEATURED_PODCAST_IMAGE_SIZE_DP)
-        ) { page ->
-            val podcast = items[page]
-            FollowedPodcastCarouselItem(
-                podcastImageUrl = podcast.imageUrl,
-                podcastTitle = podcast.title,
-                onUnfollowedClick = { onPodcastUnfollowed(podcast) },
-                lastEpisodeDateText = podcast.lastEpisodeDate?.let { lastUpdated(it) },
-                modifier = Modifier
-                    .fillMaxSize()
-                    .clickable {
-                        navigateToPodcastDetails(podcast)
-                    }
-            )
-        }
+    val screenWidthDp = LocalConfiguration.current.screenWidthDp.dp
+    val horizontalPadding = (screenWidthDp - FEATURED_PODCAST_IMAGE_SIZE_DP) / 2
+
+    HorizontalPager(
+        state = pagerState,
+        contentPadding = PaddingValues(
+            horizontal = horizontalPadding,
+            vertical = 16.dp,
+        ),
+        pageSpacing = 24.dp,
+        pageSize = PageSize.Fixed(FEATURED_PODCAST_IMAGE_SIZE_DP),
+        modifier = modifier,
+    ) { page ->
+        val podcast = items[page]
+        FollowedPodcastCarouselItem(
+            podcastImageUrl = podcast.imageUrl,
+            podcastTitle = podcast.title,
+            onUnfollowedClick = { onPodcastUnfollowed(podcast) },
+            lastEpisodeDateText = podcast.lastEpisodeDate?.let { lastUpdated(it) },
+            modifier = Modifier
+                .fillMaxSize()
+                .clickable {
+                    navigateToPodcastDetails(podcast)
+                }
+        )
     }
 }
 

From b956abd0e9d20d1162220c9e6c031e7bd2d7d534 Mon Sep 17 00:00:00 2001
From: yongsuk44 <rlarladyd@gmail.com>
Date: Mon, 25 Nov 2024 21:04:54 +0900
Subject: [PATCH 2/2] Spotless apply

---
 .../mobile/src/main/java/com/example/jetcaster/ui/home/Home.kt  | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Jetcaster/mobile/src/main/java/com/example/jetcaster/ui/home/Home.kt b/Jetcaster/mobile/src/main/java/com/example/jetcaster/ui/home/Home.kt
index 2bd59e811..dfc4bb725 100644
--- a/Jetcaster/mobile/src/main/java/com/example/jetcaster/ui/home/Home.kt
+++ b/Jetcaster/mobile/src/main/java/com/example/jetcaster/ui/home/Home.kt
@@ -22,11 +22,9 @@ import androidx.activity.compose.BackHandler
 import androidx.compose.foundation.ExperimentalFoundationApi
 import androidx.compose.foundation.background
 import androidx.compose.foundation.clickable
-import androidx.compose.foundation.gestures.snapping.SnapPosition
 import androidx.compose.foundation.layout.Arrangement
 import androidx.compose.foundation.layout.Box
 import androidx.compose.foundation.layout.BoxScope
-import androidx.compose.foundation.layout.BoxWithConstraints
 import androidx.compose.foundation.layout.Column
 import androidx.compose.foundation.layout.PaddingValues
 import androidx.compose.foundation.layout.Row