provide useful error message in ndk-build when using the wrong API level with `-static` #1390

topjohnwu · 2020-12-06T02:22:55Z

Using NDK r22-beta1 (22.0.6917172-beta1) on macOS with ndk-build to build static binaries.
Ran into issues while linking a static binary targeting API 16 with the following error message:

ld: error: duplicate symbol: swprintf
>>> defined at swprintf.cpp:38 (/Volumes/Android/buildbot/src/android/ndk-release-r22/out/darwin/android-ndk-r22-beta1/sources/android/support/src/swprintf.cpp:38)
>>>            swprintf.o:(swprintf) in archive /Volumes/Developer/android/sdk/ndk/magisk/sources/android/support/../../cxx-stl/llvm-libc++/libs/armeabi-v7a/libandroid_support.a
>>> defined at stdio.cpp:983 (bionic/libc/stdio/stdio.cpp:983)
>>>            stdio.o:(.text.swprintf+0x1) in archive /Volumes/Developer/android/sdk/ndk/magisk/toolchains/llvm/prebuilt/darwin-x86_64/bin/../sysroot/usr/lib/arm-linux-androideabi/16/libc.a

ld: error: duplicate symbol: posix_memalign
>>> defined at posix_memalign.cpp:5 (/Volumes/Android/buildbot/src/android/ndk-release-r22/out/darwin/android-ndk-r22-beta1/sources/android/support/src/posix_memalign.cpp:5)
>>>            posix_memalign.o:(posix_memalign) in archive /Volumes/Developer/android/sdk/ndk/magisk/sources/android/support/../../cxx-stl/llvm-libc++/libs/armeabi-v7a/libandroid_support.a
>>> defined at malloc_common.h:80 (bionic/libc/bionic/malloc_common.h:80)
>>>            malloc_common.o:(.text.posix_memalign+0x1) in archive /Volumes/Developer/android/sdk/ndk/magisk/toolchains/llvm/prebuilt/darwin-x86_64/bin/../sysroot/usr/lib/arm-linux-androideabi/16/libc.a
clang++: error: linker command failed with exit code 1 (use -v to see invocation)

It looks like there are duplicate symbols in libc.a and libandroid_support.a

Update: when changing the code to target API 21, the error disappears, which means the issue lies in API 16 static libs

The text was updated successfully, but these errors were encountered:

DanAlbert · 2020-12-07T20:15:18Z

Static linking is only valid when targeting the maximum supported API level.

enh-google · 2020-12-07T20:34:49Z

we can't do anything for custom build systems, but should we explicitly disallow this combination in ndk-build/cmake so we can give a clear error message rather than a link error?

DanAlbert · 2020-12-07T21:41:39Z

We can't for CMake because we can't know if there are static executables or not.

Probably could for ndk-build.

DanAlbert · 2021-02-25T00:23:44Z

Did this in https://android-review.googlesource.com/c/platform/ndk/+/1569962.

Context: https://github.com/android/ndk/wiki/Changelog-r23#changelog The most important changes for Xamarin.Android: NDK r23 removes GNU Binutils and so we need to switch to using our bundled copy of them. Upstream changes: * Includes Android 12 APIs. * Updated LLVM to clang-r416183b, based on LLVM 12 development. * [Issue 1047]: Fixes crash when using ASan with the CFI unwinder. * [Issue 1096]: Includes support for [Polly]. Enable by adding `-mllvm -polly` to your cflags. * [Issue 1230]: LLVM's libunwind is now used instead of libgcc for all architectures rather than just 32-bit Arm. * [Issue 1231]: LLVM's libclang_rt.builtins is now used instead of libgcc. * [Issue 1406]: Fixes crash with Neon intrinsic. * Vulkan validation layer source and binaries are no longer shipped in the NDK. The latest are now posted directly to [GitHub](https://github.com/KhronosGroup/Vulkan-ValidationLayers/releases). * Vulkan tools source is also removed, specifically vulkan_wrapper. It should be downloaded upstream from [GitHub](https://github.com/KhronosGroup/Vulkan-Tools). * The toolchain file (android.toolchain.cmake) is refactored to base on CMake's integrated Android support. This new toolchain file will be enabled by default for CMake 3.21 and newer. No user side change is expected. But if anything goes wrong, please file a bug and set `ANDROID_USE_LEGACY_TOOLCHAIN_FILE=ON` to restore the legacy behavior. * When using the new behavior (when using CMake 3.21+ and not explicitly selecting the legacy toolchain), **default build flags may change**. One of the primary goals was to reduce the behavior differences between our toolchain and CMake, and CMake's default flags do not always match the legacy toolchain file. Most notably, if using `CMAKE_BUILD_TYPE=Release`, your optimization type will likely be `-O3` instead of `-O2` or `-Oz`. See [Issue 1536] for more information. * [Issue 929]: `find_library` now prefers shared libraries from the sysroot over static libraries. * [Issue 1390]: ndk-build now warns when building a static executable with the wrong API level. * [Issue 1452]: `NDK_ANALYZE=1` now sets `APP_CLANG_TIDY=true` rather than using scan-build. clang-tidy performs all the same checks by default, and scan-build was no longer working. See the bug for more details, but no user-side changes should be needed. [Issue 929]: android/ndk#929 [Issue 1047]: android/ndk#1047 [Issue 1096]: android/ndk#1096 [Issue 1230]: android/ndk#1230 [Issue 1231]: android/ndk#1231 [Issue 1390]: android/ndk#1390 [Issue 1406]: android/ndk#1406 [Issue 1452]: android/ndk#1452 [Issue 1536]: android/ndk#1536 [Polly]: https://polly.llvm.org/

Context: https://github.com/android/ndk/wiki/Changelog-r23#changelog The most important changes for Xamarin.Android: NDK r23 removes GNU Binutils and so we need to switch to using our bundled copy of them. Upstream NDK r23changes: * Includes Android 12/API-31 APIs. * Updated LLVM to clang-r416183b, based on LLVM 12 development. * [Issue 1047]: Fixes crash when using ASan with the CFI unwinder. * [Issue 1096]: Includes support for [Polly]. Enable by adding `-mllvm -polly` to your cflags. * [Issue 1230]: LLVM's `libunwind` is now used instead of `libgcc` for all architectures rather than just 32-bit ARM. * [Issue 1231]: LLVM's `libclang_rt.builtins` is now used instead of `libgcc`. * [Issue 1406]: Fixes crash with Neon intrinsic. * Vulkan validation layer source and binaries are no longer shipped in the NDK. The latest are now posted directly to [KhronosGroup/Vulkan-ValidationLayers]. * Vulkan tools source is also removed, specifically `vulkan_wrapper`. It should be downloaded upstream from [KhronosGroup/Vulkan-Tools]. * Refactored the toolchain file `android.toolchain.cmake`, basing it on CMake's integrated Android support. This new toolchain file will be enabled by default for CMake 3.21 and newer. No user side change is expected. But if anything goes wrong, please file a bug and set `ANDROID_USE_LEGACY_TOOLCHAIN_FILE=ON` to restore the legacy behavior. * When using the new behavior (when using CMake 3.21+ and not explicitly selecting the legacy toolchain), **default build flags may change**. One of the primary goals was to reduce the behavior differences between our toolchain and CMake, and CMake's default flags do not always match the legacy toolchain file. Most notably, if using `CMAKE_BUILD_TYPE=Release`, your optimization type will likely be `-O3` instead of `-O2` or `-Oz`. See [Issue 1536] for more information. * [Issue 929]: `find_library` now prefers shared libraries from the sysroot over static libraries. * [Issue 1390]: `ndk-build` now warns when building a static executable with the wrong API level. * [Issue 1452]: `NDK_ANALYZE=1` now sets `APP_CLANG_TIDY=true` rather than using `scan-build`. `clang-tidy` performs all the same checks by default, and `scan-build` was no longer working. See [Issue 1452] for more details; no user-side changes should be needed. [Issue 929]: android/ndk#929 [Issue 1047]: android/ndk#1047 [Issue 1096]: android/ndk#1096 [Issue 1230]: android/ndk#1230 [Issue 1231]: android/ndk#1231 [Issue 1390]: android/ndk#1390 [Issue 1406]: android/ndk#1406 [Issue 1452]: android/ndk#1452 [Issue 1536]: android/ndk#1536 [Polly]: https://polly.llvm.org/ [KhronosGroup/Vulkan-ValidationLayers]: https://github.com/KhronosGroup/Vulkan-ValidationLayers/releases [KhronosGroup/Vulkan-Tools]: https://github.com/KhronosGroup/Vulkan-Tools

topjohnwu added the bug label Dec 6, 2020

topjohnwu changed the title ~~[BUG] Duplicate symbols in libc.a and libandroid_support.a~~ [BUG] Duplicate symbols in libc.a and libandroid_support.a Dec 6, 2020

DanAlbert closed this as completed Dec 7, 2020

DanAlbert reopened this Dec 7, 2020

DanAlbert closed this as completed Dec 7, 2020

DanAlbert reopened this Dec 7, 2020

DanAlbert changed the title ~~[BUG] Duplicate symbols in libc.a and libandroid_support.a~~ provide useful error message in ndk-build when using the wrong API level with -static Dec 7, 2020

DanAlbert added enhancement and removed bug labels Dec 7, 2020

DanAlbert closed this as completed Feb 25, 2021

grendello mentioned this issue Aug 16, 2021

Add support for NDK r23. dotnet/android#6073

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

provide useful error message in ndk-build when using the wrong API level with `-static` #1390

provide useful error message in ndk-build when using the wrong API level with `-static` #1390

topjohnwu commented Dec 6, 2020 •

edited

Loading

DanAlbert commented Dec 7, 2020

enh-google commented Dec 7, 2020

DanAlbert commented Dec 7, 2020

DanAlbert commented Feb 25, 2021

provide useful error message in ndk-build when using the wrong API level with -static #1390

provide useful error message in ndk-build when using the wrong API level with -static #1390

Comments

topjohnwu commented Dec 6, 2020 • edited Loading

DanAlbert commented Dec 7, 2020

enh-google commented Dec 7, 2020

DanAlbert commented Dec 7, 2020

DanAlbert commented Feb 25, 2021

provide useful error message in ndk-build when using the wrong API level with `-static` #1390

provide useful error message in ndk-build when using the wrong API level with `-static` #1390

topjohnwu commented Dec 6, 2020 •

edited

Loading