unused module errors #269
Merged
unused module errors #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
brianmcgillion
force-pushed
the
tmp-display
branch
from
1413da2 to
d0b7275
Compare
brianmcgillion
changed the title
hacker1024
reviewed
Feb 5, 2025
NixOS/nixpkgs#366004 introduced a change that warns and errors out when modules are defined and not acutally set for a particular target. This patch rectifies that by going back the the previous method of ignoring those errors and not breaking the build. Commentary is left inline to explain the situation and possible future solutions. tested against orin agx target for ghaf. there are similar solutions being deployed in nixpkgs to work around this e.g. NixOS/nixpkgs#375165 Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
brianmcgillion
force-pushed
the
tmp-display
branch
from
d0b7275 to
d1c8212
Compare
|
LGTM, thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
NixOS/nixpkgs#366004 introduced a change that
warns and errors out when modules are defined and not acutally set for a
particular target.
This patch rectifies that by going back the the previous method of
ignoring those errors and not breaking the build. Commentary is left
inline to explain the situation and possible future solutions.
tested against orin agx target for ghaf.
there are similar solutions being deployed in nixpkgs to work around
this e.g.
NixOS/nixpkgs#375165
Testing