From 7a22978431af459ae7b268156c4f3a8313f84631 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Est=C3=A9ban?= <103997512+esoubiran-aneo@users.noreply.github.com> Date: Tue, 2 May 2023 09:42:40 +0200 Subject: [PATCH] Apply suggestions from code review --- .docs/content/0.armonik/0.index.md | 2 +- .docs/content/2.guide/1.how-to/how-to-configure-seq.md | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.docs/content/0.armonik/0.index.md b/.docs/content/0.armonik/0.index.md index a53f2da2b..a34ad77b5 100644 --- a/.docs/content/0.armonik/0.index.md +++ b/.docs/content/0.armonik/0.index.md @@ -10,7 +10,7 @@ This project is an Open Source ([Apache 2.0 License](https://github.com/aneocons ## When should I use ArmoniK -ArmoniK should be used when the following criteria are meet: +ArmoniK should be used when the following criteria are met: 1. A high task throughput is required (from 250 to 10,000+ tasks per second). 2. The tasks are loosely coupled. diff --git a/.docs/content/2.guide/1.how-to/how-to-configure-seq.md b/.docs/content/2.guide/1.how-to/how-to-configure-seq.md index b3d4bf8ee..d68257ff1 100644 --- a/.docs/content/2.guide/1.how-to/how-to-configure-seq.md +++ b/.docs/content/2.guide/1.how-to/how-to-configure-seq.md @@ -1,6 +1,6 @@ # How to configure SEQ? -If you want to access outside your kubernetes cluster, you have to configure seq to make it accessible from outside. +If you want to access outside your Kubernetes cluster, you have to configure Seq to make it accessible from outside. To do so, you have to set this service (`seq_web` in [seq.tf](../old/armonik-deployments/armonik/modules/armonik-components/seq.tf#L92) ) as `LoadBalancer` instead of `ClusterIP`. Then, redeploy. @@ -27,7 +27,7 @@ The application name for the worker is `ArmoniK.Compute.Worker`. (Application = ## Troubleshoot -If you use docker as the kubernetes backend, you should configure the logging driver of docker to `json-file`. +If you use docker as the Kubernetes backend, you should configure the logging driver of docker to `json-file`. Otherwise, the logs will remain empty (fluent-bit will not be able to fetch logs). https://docs.docker.com/config/containers/logging/configure/#configure-the-default-logging-driver