fix(core): remove unnecessary untracked

Author: nartc

libs/core/src/lib/canvas.ts

@@ -147,13 +147,11 @@ export class NgtCanvas {
 					this.zone.runOutsideAngular(() => {
 						configurator.configure(canvasOptions);
 
-						untracked(() => {
-							if (this.glRef) {
-								this.glRef.changeDetectorRef.detectChanges();
-							} else {
-								this.noZoneRender();
-							}
-						});
+						if (this.glRef) {
+							this.glRef.changeDetectorRef.detectChanges();
+						} else {
+							this.noZoneRender();
+						}
 					});
 				},
 				{ injector: this.injector },

libs/core/src/lib/directives/args.ts

@@ -6,7 +6,6 @@ import {
 	inject,
 	input,
 	TemplateRef,
-	untracked,
 	ViewContainerRef,
 } from '@angular/core';
 import { SPECIAL_INTERNAL_ADD_COMMENT } from '../renderer/constants';
@@ -34,9 +33,7 @@ export class NgtArgs {
 			if (value == null || !Array.isArray(value) || (value.length === 1 && value[0] === null)) return;
 			this.injected = false;
 			this.injectedArgs = value;
-			untracked(() => {
-				this.createView();
-			});
+			this.createView();
 		});
 
 		inject(DestroyRef).onDestroy(() => {

libs/core/src/lib/directives/selection.ts

@@ -23,43 +23,40 @@ export class NgtSelect {
 		const elementRef = inject<ElementRef<Group | Mesh>>(ElementRef);
 		const selection = inject(NgtSelection);
 
-		effect(
-			(onCleanup) => {
-				const selectionEnabled = selection.enabled();
-				if (!selectionEnabled) return;
-
-				const enabled = this.enabled();
-				if (!enabled) return;
-
-				const host = elementRef.nativeElement;
-				if (!host) return;
-
-				const localState = getLocalState(host);
-				if (!localState) return;
-
-				// ngt-mesh[ngtSelect]
-				if (host.type === 'Mesh') {
-					selection.update((prev) => [...prev, host]);
-					onCleanup(() => selection.update((prev) => prev.filter((el) => el !== host)));
-					return;
-				}
-
-				const [collection] = [untracked(selection.selected), localState.objects()];
-				let changed = false;
-				const current: Object3D[] = [];
-				host.traverse((child) => {
-					child.type === 'Mesh' && current.push(child);
-					if (collection.indexOf(child) === -1) changed = true;
-				});
-
-				if (!changed) return;
-
-				selection.update((prev) => [...prev, ...current]);
-				onCleanup(() => {
-					selection.update((prev) => prev.filter((el) => !current.includes(el as Object3D)));
-				});
-			},
-			{ allowSignalWrites: true },
-		);
+		effect((onCleanup) => {
+			const selectionEnabled = selection.enabled();
+			if (!selectionEnabled) return;
+
+			const enabled = this.enabled();
+			if (!enabled) return;
+
+			const host = elementRef.nativeElement;
+			if (!host) return;
+
+			const localState = getLocalState(host);
+			if (!localState) return;
+
+			// ngt-mesh[ngtSelect]
+			if (host.type === 'Mesh') {
+				selection.update((prev) => [...prev, host]);
+				onCleanup(() => selection.update((prev) => prev.filter((el) => el !== host)));
+				return;
+			}
+
+			const [collection] = [untracked(selection.selected), localState.objects()];
+			let changed = false;
+			const current: Object3D[] = [];
+			host.traverse((child) => {
+				child.type === 'Mesh' && current.push(child);
+				if (collection.indexOf(child) === -1) changed = true;
+			});
+
+			if (!changed) return;
+
+			selection.update((prev) => [...prev, ...current]);
+			onCleanup(() => {
+				selection.update((prev) => prev.filter((el) => !current.includes(el as Object3D)));
+			});
+		});
 	}
 }

libs/core/src/lib/portal.ts

@@ -204,21 +204,20 @@ export class NgtPortal {
 				() => {
 					const state = this.state();
 					const _parentState = parentState();
+
 					this.portalStore.update((prev) => this.inject(_parentState, prev, state, untracked(this.container)));
-					untracked(() => {
-						if (this.portalView) {
-							this.portalView.detectChanges();
-							return;
-						}
-
-						this.portalView = this.portalAnchor().createEmbeddedView(
-							this.portalContent(),
-							{ container: this.container(), injector: this.injector },
-							{ injector: this.injector },
-						);
+					if (this.portalView) {
 						this.portalView.detectChanges();
-						this.portalRendered.set(true);
-					});
+						return;
+					}
+
+					this.portalView = untracked(this.portalAnchor).createEmbeddedView(
+						untracked(this.portalContent),
+						{ container: untracked(this.container), injector: this.injector },
+						{ injector: this.injector },
+					);
+					this.portalView.detectChanges();
+					this.portalRendered.set(true);
 				},
 				{ injector: this.injector },
 			);

libs/core/src/lib/utils/signal-store.ts

@@ -89,6 +89,7 @@ function reducer<State extends object>(state: State | ((previous: State) => Stat
 function updater<State extends object>(_source: WritableSignal<State>) {
 	return (state: State | ((previous: State) => State)) => {
 		const updater = reducer(state);
+		// TODO: (chau) I'm keeping this one around for now.
 		untracked(() => {
 			_source.update((previous) => ({ ...previous, ...updater(previous) }));
 		});