Datepicker shows two October 19, 2013 dates! Live at AngularJS UI website

[jbruni]

Guys... my client told me datepicker was showing two October 19 2013 dates...

To my surprise, not only he is correct, but also had nothing to do with my particular app...

Just go to http://angular-ui.github.io/bootstrap/#/datepicker and move the month forward (we are currently in September, as I write this), and you will see October 19 both as Saturday and repeated as Sunday!

I call "urgency" because we are about to launch this app... and because we can easily see the issue while still in September.

[caitp]

I can't reproduce this on FF26 or Chrome29

[jbruni]

I'm seeing both at Chrome 29.0.1547.65 and Firefox 23.0 in Ubuntu 12.04 64 bits install.

[pkozlowski-opensource]

Same here, can't reproduce, tried different browsers... @jbruni I'm afraid that you (or someone else who can reproduce) will have to debug to see what is going on.

[jbruni]

Curious... I would think the problem could be at my machine if it wasn't reported to me by someone else.

What GMT are you? Can you localize yourselves at a distinct timezone? I'm at GMT-3.

Just wondering... I will investigate... let's see if I can find something.

[bekos]

@jbruni Can't reproduce also. At least provide a screeshot from our demo page and info about your timezone.

BTW I don't think this a CRM forum to call thinks URGENT or not!!!

[hallister]

Tested this is Chrome 28 and Firefox 24 on both Ubuntu 12.04 and 13.04 and couldn't reproduce.

[caitp]

I'm in GMT-4 at the moment

[jbruni]

Timezone: America/Sao_Paulo

Screenshots:

[caitp]

It certainly wouldn't be the first time in the history of web apps that this sort of bug manifested itself -- But I think it will take at a minimum a few hours to investigate and figure out why. I don't mind taking a look in an hour or so, but I'll be occupied until then. Why not have a go at it?

[jbruni]

Hey, guys, hot clues! Here is what I did:

  function getDates(startDate, n) {
    var dates = new Array(n), abc;
    var current = startDate, i = 0;
    while (i < n) {
      dates[i++] = new Date(current);
      abc = current.getDate() + 1;
      console.log( i + ' => ' + abc );
      current.setDate( abc );
    }
    return dates;
  }

This is substituting the getDates function here: https://github.com/angular-ui/bootstrap/blob/master/src/datepicker/datepicker.js#L40 - the single purpose of the change is to have the console output.

Here is what appears at console:

Note that the value "20" appears twice, repeated for both i = 20 and i = 21

More info: for the debugged getDates call, startDate = Mon Sep 30 2013 00:00:00 GMT-0300 (BRT) and n = 35

[jbruni]

Guys, please check this: http://plnkr.co/edit/h4JrvS?p=preview (needs console opened to see the results)

Let me know if the results in your console are the same as above (repeated results for i = 20 and i = 21).

If so, we at least succesfully reproduced the issue...

[bekos]

@jbruni Plunker does not work for me. Check again.

[jbruni]

Ok, guys... found a fix, works like a charm to me. I hope others can reproduce the issue, so they can reproduce the fix too: #1101

In short: just use UTC functions in getDates - it is a timezone issue.

[I must focus back in my app development. Tight deadline approaching...]

Thank you.

[jbruni]

@marcospassos - you are at same timezone and country - can you please check the datepicker at http://angular-ui.github.io/bootstrap/#/datepicker - and see if there are two October 19 appearing there?

Any other brazilian developer to check? @ThCC, please...? @estudio203!

[caitp]

I've just tested -- I don't see any repeated dates in October in the returned array. However keep in mind startDate is actually reported wildly incorrectly. Not too sure about this.

On 2013-09-30, at 11:44 AM, J Bruni notifications@github.com wrote:

Guys, please check this: http://plnkr.co/edit/h4JrvS?p=preview (needs console opened to see the results)

Let me know if the results in your console are the same as above (repeated results for i = 20 and i = 21).

If so, we at least succesfully reproduced the issue...

—
Reply to this email directly or view it on GitHub.