Pagination control does not support keyboard access

[squareplanetdesign]

Since the elements in the template do not have href defined, in most browsers you can not tab through the controls for the pages.

I was experimenting and found that adding href="javascript:void(0)" the {tab} key would correctly focus each of the elements of the pagination control.

[pkozlowski-opensource]

Yeh, lack of this href attribute is also causing other issues with the CSS styling... We've decided to remove those from templates as it was causing some issues with routing for different people...

Not sure what is the best course of action here, your work-arround sounds reasonable.

[squareplanetdesign]

I am not seeing routing issues with javascript:void(0) at least for my applications.

[bekos]

@squareplanetdesign Adding javascript:void(0) is considered bad practice.
@pkozlowski-opensource Maybe we should reconsider adding the empty href. Maybe the issue has been solved from Angular or the root of the problem was caused by bad use in user's application. This will solve the CSS issues and will help significantly providing ARIA support.

[pkozlowski-opensource]

@bekos Let's add those empty hrefs. Honestly I was never able to make people to send a minimal reproduce scenario to pinpoint the issue. I'm sure there is an issue in there but as I've said, I'm not sure what this whole thing is about.

So yes, let's try to add back all those empty hrefs and when someone comes with a problem let's insist on a minimal reproduce scenario. We should do it for tabs and accordions as well I guess.

[bekos]

@pkozlowski-opensource Agree.

[squareplanetdesign]

One other though I had on this was having the ability to explicitly set the href with a router path. Something like:

href="#/books/page/1"

and setup a compatible router:

$routeProvider.when('/books/page/:pageid', ...);

The directive would have to be extended to support some kind of route template mechanism.

That way it could work directly with routers

[bekos]

Empty href attributes have been added to pagination directives via 101c43a.