From c1df1f857cef2e8b77af202851c0d7c3ea510a49 Mon Sep 17 00:00:00 2001 From: Wesley Cho Date: Sun, 2 Aug 2015 09:21:48 -0700 Subject: [PATCH] fix(typeahead): return `null` if empty - Return `null` instead to unify falsy values --- src/typeahead/test/typeahead.spec.js | 2 +- src/typeahead/typeahead.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/typeahead/test/typeahead.spec.js b/src/typeahead/test/typeahead.spec.js index e8e4411ece..259f8feb1e 100644 --- a/src/typeahead/test/typeahead.spec.js +++ b/src/typeahead/test/typeahead.spec.js @@ -258,7 +258,7 @@ describe('typeahead tests', function () { expect($scope.result).toEqual(undefined); expect($scope.form.input.$error.editable).toBeTruthy(); changeInputValueTo(element, ''); - expect($scope.result).toEqual(''); + expect($scope.result).toEqual(null); expect($scope.form.input.$error.editable).toBeFalsy(); }); diff --git a/src/typeahead/typeahead.js b/src/typeahead/typeahead.js index bc6c57146d..3fa0c2a813 100644 --- a/src/typeahead/typeahead.js +++ b/src/typeahead/typeahead.js @@ -290,7 +290,7 @@ angular.module('ui.bootstrap.typeahead', ['ui.bootstrap.position', 'ui.bootstrap if (!inputValue) { // Reset in case user had typed something previously. modelCtrl.$setValidity('editable', true); - return inputValue; + return null; } else { modelCtrl.$setValidity('editable', false); return undefined;