From 4b805c7535101f61c9ec854d011200077b38137c Mon Sep 17 00:00:00 2001 From: Sumit Arora Date: Wed, 7 Jun 2017 10:21:01 -0400 Subject: [PATCH] fix(@angular/cli): fix empty style urls --- packages/@ngtools/webpack/src/loader.ts | 2 +- .../tests/build/styles/empty-style-urls.ts | 24 +++++++++++++++++++ 2 files changed, 25 insertions(+), 1 deletion(-) create mode 100644 tests/e2e/tests/build/styles/empty-style-urls.ts diff --git a/packages/@ngtools/webpack/src/loader.ts b/packages/@ngtools/webpack/src/loader.ts index 5dd0c0f7ab4d..d8e52aacf171 100644 --- a/packages/@ngtools/webpack/src/loader.ts +++ b/packages/@ngtools/webpack/src/loader.ts @@ -361,7 +361,7 @@ function _getResourcesUrls(refactor: TypeScriptFileRefactor): string[] { const arr = ( refactor.findAstNodes(node, ts.SyntaxKind.ArrayLiteralExpression, false)); if (!arr || arr.length == 0 || arr[0].elements.length == 0) { - return; + return acc; } arr[0].elements.forEach((element: ts.Expression) => { diff --git a/tests/e2e/tests/build/styles/empty-style-urls.ts b/tests/e2e/tests/build/styles/empty-style-urls.ts new file mode 100644 index 000000000000..7f894371c007 --- /dev/null +++ b/tests/e2e/tests/build/styles/empty-style-urls.ts @@ -0,0 +1,24 @@ +import { writeMultipleFiles } from '../../../utils/fs'; +import { ng } from '../../../utils/process'; + + +export default function () { + + return Promise.resolve() + // Write assets. + .then(_ => writeMultipleFiles({ + './src/app/app.component.ts': ` + import { Component } from '@angular/core'; + + @Component({ + selector: 'app-root', + templateUrl: './app.component.html', + styleUrls: [] + }) + export class AppComponent { + title = 'app'; + } + ` + })) + .then(() => ng('build')); +}