From 5a2766975edbc97031edc139b49c26fb2bea0334 Mon Sep 17 00:00:00 2001 From: Sean Larkin Date: Sun, 24 Jul 2016 22:55:46 -0500 Subject: [PATCH] feat: add host flag support for ng serve --- addon/ng2/commands/serve.ts | 4 ++-- addon/ng2/tasks/serve-webpack.ts | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/addon/ng2/commands/serve.ts b/addon/ng2/commands/serve.ts index 4880f1fd2c52..7e048aff2a39 100644 --- a/addon/ng2/commands/serve.ts +++ b/addon/ng2/commands/serve.ts @@ -37,7 +37,7 @@ module.exports = Command.extend({ availableOptions: [ { name: 'port', type: Number, default: defaultPort, aliases: ['p'] }, - { name: 'host', type: String, aliases: ['H'], description: 'Listens on all interfaces by default' }, + { name: 'host', type: String, default: 'localhost', aliases: ['H'], description: 'Listens on all interfaces by default' }, { name: 'proxy', type: String, aliases: ['pr', 'pxy'] }, { name: 'insecure-proxy', type: Boolean, default: false, aliases: ['inspr'], description: 'Set false to proxy self-signed SSL certificates' }, { name: 'watcher', type: String, default: 'events', aliases: ['w'] }, @@ -61,7 +61,7 @@ module.exports = Command.extend({ } if (commandOptions.target === 'production') { commandOptions.environment = 'prod'; - } + } } commandOptions.liveReloadHost = commandOptions.liveReloadHost || commandOptions.host; diff --git a/addon/ng2/tasks/serve-webpack.ts b/addon/ng2/tasks/serve-webpack.ts index ff797cd6d050..60589e48c011 100644 --- a/addon/ng2/tasks/serve-webpack.ts +++ b/addon/ng2/tasks/serve-webpack.ts @@ -11,14 +11,14 @@ import { CliConfig } from '../models/config'; module.exports = Task.extend({ run: function(commandOptions: ServeTaskOptions) { - + let lastHash = null; let webpackCompiler: any; var config: NgCliWebpackConfig = new NgCliWebpackConfig(this.project, commandOptions.target, commandOptions.environment).config; // This allows for live reload of page when changes are made to repo. // https://webpack.github.io/docs/webpack-dev-server.html#inline-mode - config.entry.main.unshift(`webpack-dev-server/client?http://localhost:${commandOptions.port}/`); + config.entry.main.unshift(`webpack-dev-server/client?http://${commandOptions.host}:${commandOptions.port}/`); webpackCompiler = webpack(config); webpackCompiler.apply(new ProgressPlugin({ @@ -33,11 +33,11 @@ module.exports = Task.extend({ inline: true }; - const serveMessage:string = chalk.green(`\n*\n*\n NG Live Development Server is running on http://localhost:${commandOptions.port}.\n*\n*`); + const serveMessage:string = chalk.green(`\n*\n*\n NG Live Development Server is running on http://${commandOptions.host}:${commandOptions.port}.\n*\n*`); const server = new WebpackDevServer(webpackCompiler, webpackDevServerConfiguration); return new Promise((resolve, reject) => { - server.listen(commandOptions.port, 'localhost', function(err, stats) { + server.listen(commandOptions.port, `${commandOptions.host}`, function(err, stats) { if(err) { lastHash = null; console.error(err.stack || err);