From 996ff17d9e0bd85a637768a1e4a0a74024d8b0df Mon Sep 17 00:00:00 2001 From: Charles Lyding <19598772+clydin@users.noreply.github.com> Date: Tue, 25 Mar 2025 16:42:55 -0400 Subject: [PATCH] test: improve resilience of asset timestamp E2E test The test now uses an asset that is already on disk. Using an asset that was just written within the test may cause timestamps to not yet be synced to disk. --- tests/legacy-cli/e2e/tests/build/assets.ts | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/legacy-cli/e2e/tests/build/assets.ts b/tests/legacy-cli/e2e/tests/build/assets.ts index 1875268c5afe..fbd5f8f70a6c 100644 --- a/tests/legacy-cli/e2e/tests/build/assets.ts +++ b/tests/legacy-cli/e2e/tests/build/assets.ts @@ -11,7 +11,8 @@ const isNodeV22orHigher = Number(process.versions.node.split('.', 1)[0]) >= 22; export default async function () { await writeFile('public/.file', ''); await writeFile('public/test.abc', 'hello world'); - const originalStats = fs.statSync('public/test.abc', { bigint: true }); + + const originalStats = fs.statSync('public/favicon.ico', { bigint: true }); await ng('build', '--configuration=development'); @@ -22,9 +23,10 @@ export default async function () { // Timestamp preservation only supported with application build system on Node.js v22+ if (isNodeV22orHigher && getGlobalVariable('argv')['esbuild']) { - const outputStats = fs.statSync('dist/test-project/browser/test.abc', { bigint: true }); - assert( - originalStats.mtimeMs === outputStats.mtimeMs, + const outputStats = fs.statSync('dist/test-project/browser/favicon.ico', { bigint: true }); + assert.equal( + originalStats.mtimeMs, + outputStats.mtimeMs, 'Asset file modified timestamp should be preserved.', ); }