diff --git a/src/ng/parse.js b/src/ng/parse.js index 403442560e4b..f6c853583951 100644 --- a/src/ng/parse.js +++ b/src/ng/parse.js @@ -754,6 +754,7 @@ Parser.prototype = { } var fnPtr = fn(scope, locals, context) || noop; + ensureSafeObject(context, parser.text); ensureSafeObject(fnPtr, parser.text); // IE stupidity! (IE doesn't have apply for some native functions) diff --git a/test/ng/parseSpec.js b/test/ng/parseSpec.js index 940bd6d6f6e6..d7d0d94169de 100644 --- a/test/ng/parseSpec.js +++ b/test/ng/parseSpec.js @@ -730,6 +730,20 @@ describe('parser', function() { '$parse', 'isecdom', 'Referencing DOM nodes in Angular expressions is ' + 'disallowed! Expression: getDoc()'); })); + + it('should NOT allow calling functions on Window or DOM', inject(function($window, $document) { + scope.a = {b: { win: $window, doc: $document }}; + expect(function() { + scope.$eval('a.b.win.alert(1)', scope); + }).toThrowMinErr( + '$parse', 'isecwindow', 'Referencing the Window in Angular expressions is ' + + 'disallowed! Expression: a.b.win.alert(1)'); + expect(function() { + scope.$eval('a.b.doc.on("click")', scope); + }).toThrowMinErr( + '$parse', 'isecdom', 'Referencing DOM nodes in Angular expressions is ' + + 'disallowed! Expression: a.b.doc.on("click")'); + })); }); });