From 4b71bbc9886f6cf8e939d257c755bf7c4a94396e Mon Sep 17 00:00:00 2001 From: Chirayu Krishnappa Date: Tue, 17 Sep 2013 16:09:29 -0700 Subject: [PATCH] fix(test): fixed toThrow usage --- test/ng/directive/ngIncludeSpec.js | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/test/ng/directive/ngIncludeSpec.js b/test/ng/directive/ngIncludeSpec.js index f1bfbba21c7c..ffe6a9982c38 100644 --- a/test/ng/directive/ngIncludeSpec.js +++ b/test/ng/directive/ngIncludeSpec.js @@ -64,14 +64,16 @@ describe('ngInclude', function() { })); - it('should NOT use untrusted expressions ', inject(putIntoCache('myUrl', '{{name}} text'), + it('should NOT use untrusted URL expressions ', inject(putIntoCache('myUrl', '{{name}} text'), function($rootScope, $compile, $sce) { element = jqLite(''); jqLite(document.body).append(element); element = $compile(element)($rootScope); $rootScope.name = 'chirayu'; - $rootScope.url = 'myUrl'; - expect($rootScope.$digest).toThrow(); + $rootScope.url = 'http://example.com/myUrl'; + expect(function() { $rootScope.$digest(); }).toThrowMinErr( + '$sce', 'insecurl', + /Blocked loading resource from url not allowed by \$sceDelegate policy. URL: http:\/\/example.com\/myUrl.*/); jqLite(document.body).html(''); })); @@ -82,11 +84,14 @@ describe('ngInclude', function() { jqLite(document.body).append(element); element = $compile(element)($rootScope); $rootScope.name = 'chirayu'; - $rootScope.url = $sce.trustAsUrl('myUrl'); - expect($rootScope.$digest).toThrow(); + $rootScope.url = $sce.trustAsUrl('http://example.com/myUrl'); + expect(function() { $rootScope.$digest(); }).toThrowMinErr( + '$sce', 'insecurl', + /Blocked loading resource from url not allowed by \$sceDelegate policy. URL: http:\/\/example.com\/myUrl.*/); jqLite(document.body).html(''); })); + it('should remove previously included text if a falsy value is bound to src', inject( putIntoCache('myUrl', '{{name}}'), function($rootScope, $compile) {