Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

docs: fix the 'view source' button for snapshots #5641

Closed
wants to merge 1 commit into from

Conversation

Narretz
Copy link
Contributor

@Narretz Narretz commented Jan 5, 2014

this potentially breaks every time the format of gruntUtil.getVersion().full changes

fixes #5590

@IgorMinar
Copy link
Contributor

I'm sorry, but I wasn't able to verify your CLA signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let me know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@Narretz
Copy link
Contributor Author

Narretz commented Jan 6, 2014

I signed the CLA after the pull request.

@ghost ghost assigned IgorMinar Jan 7, 2014
@IgorMinar
Copy link
Contributor

we should write a unit test for this. would you mind doing that?

@Narretz
Copy link
Contributor Author

Narretz commented Jan 7, 2014

I'll give it a shot. I guess the test should check if the generated url is in the correct format, yes?

@bbhoss
Copy link
Contributor

bbhoss commented Jan 7, 2014

This is extremely annoying and an easy fix. Please merge this so I don't have to keep manually editing the URL. I fixed this and was about to send a pull request when I saw this. Now this will probably sit here forever waiting on a unit test for docs.

@IgorMinar
Copy link
Contributor

@bbhoss feel free to post a PR with the missing test

@IgorMinar
Copy link
Contributor

@bbhoss nevermind. I'll just do it. but next time please do send a PR with a test instead of posting a comment like that.

@IgorMinar IgorMinar closed this in 36c9e42 Jan 10, 2014
@bbhoss
Copy link
Contributor

bbhoss commented Jan 10, 2014

@IgorMinar Didn't mean to come off as rude, it's just that this issue was really annoying, and you know as well as I do how often "waiting on a test" is the death status to many pull requests. I spent about a half hour trying to figure out how to test this change, as the function is buried a few levels deep and I didn't really understand Doc at all. Thanks for writing the test!

jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: “View source” buttons in the API reference are linked to 404 page (again)
3 participants