-
Notifications
You must be signed in to change notification settings - Fork 27.5k
docs: fix the 'view source' button for snapshots #5641
Conversation
I'm sorry, but I wasn't able to verify your CLA signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let me know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
I signed the CLA after the pull request. |
we should write a unit test for this. would you mind doing that? |
I'll give it a shot. I guess the test should check if the generated url is in the correct format, yes? |
This is extremely annoying and an easy fix. Please merge this so I don't have to keep manually editing the URL. I fixed this and was about to send a pull request when I saw this. Now this will probably sit here forever waiting on a unit test for docs. |
@bbhoss feel free to post a PR with the missing test |
@bbhoss nevermind. I'll just do it. but next time please do send a PR with a test instead of posting a comment like that. |
@IgorMinar Didn't mean to come off as rude, it's just that this issue was really annoying, and you know as well as I do how often "waiting on a test" is the death status to many pull requests. I spent about a half hour trying to figure out how to test this change, as the function is buried a few levels deep and I didn't really understand Doc at all. Thanks for writing the test! |
this potentially breaks every time the format of gruntUtil.getVersion().full changes
fixes #5590