From 588a28ee8fe47e897b7a4aef47db429a94857528 Mon Sep 17 00:00:00 2001 From: Nick Eddy Date: Thu, 3 Apr 2014 13:09:32 -0700 Subject: [PATCH] fix(ngHref): allow setting href to empty string modified: src/ng/directive/booleanAttrs.js modified: test/ng/directive/booleanAttrsSpec.js --- src/ng/directive/booleanAttrs.js | 2 +- test/ng/directive/booleanAttrsSpec.js | 12 ++++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/src/ng/directive/booleanAttrs.js b/src/ng/directive/booleanAttrs.js index e98a61034063..627bcc8ced4b 100644 --- a/src/ng/directive/booleanAttrs.js +++ b/src/ng/directive/booleanAttrs.js @@ -380,7 +380,7 @@ forEach(['src', 'srcset', 'href'], function(attrName) { } attr.$observe(normalized, function(value) { - if (!value) + if (!value && attrName === 'src') return; attr.$set(name, value); diff --git a/test/ng/directive/booleanAttrsSpec.js b/test/ng/directive/booleanAttrsSpec.js index 2d800f5b3ab9..a1e598ad6f0d 100644 --- a/test/ng/directive/booleanAttrsSpec.js +++ b/test/ng/directive/booleanAttrsSpec.js @@ -246,6 +246,18 @@ describe('ngHref', function() { })); + it('should remote href value when interpolated value is empty', inject(function($compile, $rootScope) { + element = $compile('
')($rootScope); + $rootScope.$digest(); + expect(element.attr('href')).toEqual(''); + + $rootScope.$apply(function() { + $rootScope.id = 1; + }); + expect(element.attr('href')).toEqual('1'); + })); + + it('should bind href even if no interpolation', inject(function($rootScope, $compile) { element = $compile('')($rootScope) $rootScope.$digest();