From 31671f762f39a1b107b038b961c0f1223b1c7a0a Mon Sep 17 00:00:00 2001 From: Tyler Eich Date: Fri, 3 Jan 2014 18:51:52 -0500 Subject: [PATCH 1/6] Bust mousedown events Safari on iOS sends a mousedown event. This triggers ng-click-active again after touchstart, which can mess up CSS that depends on this class. --- src/ngTouch/directive/ngClick.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/ngTouch/directive/ngClick.js b/src/ngTouch/directive/ngClick.js index 10ae3efc07bb..870f19c97821 100644 --- a/src/ngTouch/directive/ngClick.js +++ b/src/ngTouch/directive/ngClick.js @@ -169,6 +169,7 @@ ngTouch.directive('ngClick', ['$parse', '$timeout', '$rootElement', function preventGhostClick(x, y) { if (!touchCoordinates) { $rootElement[0].addEventListener('click', onClick, true); + $rootElement[0].addEventListener('mousedown', onClick, true); $rootElement[0].addEventListener('touchstart', onTouchStart, true); touchCoordinates = []; } From 67dec8cfd4abfef93e73b6712ca3188462e59105 Mon Sep 17 00:00:00 2001 From: Tyler Eich Date: Tue, 6 May 2014 19:07:50 -0400 Subject: [PATCH 2/6] Support for range input --- src/ng/directive/input.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/ng/directive/input.js b/src/ng/directive/input.js index e264db38e5b0..20d964aa8b0a 100644 --- a/src/ng/directive/input.js +++ b/src/ng/directive/input.js @@ -159,6 +159,7 @@ var inputType = { */ 'number': numberInputType, + 'range': numberInputType, /** From 03b6504af3fcf1435e05134c5873cee8ea93d0b6 Mon Sep 17 00:00:00 2001 From: Tyler Eich Date: Tue, 6 May 2014 19:10:06 -0400 Subject: [PATCH 3/6] Revert "Support for range input" This reverts commit 67dec8cfd4abfef93e73b6712ca3188462e59105. --- src/ng/directive/input.js | 1 - 1 file changed, 1 deletion(-) diff --git a/src/ng/directive/input.js b/src/ng/directive/input.js index 20d964aa8b0a..e264db38e5b0 100644 --- a/src/ng/directive/input.js +++ b/src/ng/directive/input.js @@ -159,7 +159,6 @@ var inputType = { */ 'number': numberInputType, - 'range': numberInputType, /** From 6381ae3c8880f3d3a152ecf1ddd5acf6ae43b4a9 Mon Sep 17 00:00:00 2001 From: Tyler Eich Date: Tue, 6 May 2014 19:13:07 -0400 Subject: [PATCH 4/6] Revert "Support for range input" This reverts commit 67dec8cfd4abfef93e73b6712ca3188462e59105. --- src/ng/directive/input.js | 1 - 1 file changed, 1 deletion(-) diff --git a/src/ng/directive/input.js b/src/ng/directive/input.js index 20d964aa8b0a..e264db38e5b0 100644 --- a/src/ng/directive/input.js +++ b/src/ng/directive/input.js @@ -159,7 +159,6 @@ var inputType = { */ 'number': numberInputType, - 'range': numberInputType, /** From 1848e99b589323d0396dd0115ecc672333ad81f6 Mon Sep 17 00:00:00 2001 From: Tyler Eich Date: Tue, 6 May 2014 19:13:22 -0400 Subject: [PATCH 5/6] Revert "Bust mousedown events" This reverts commit 31671f762f39a1b107b038b961c0f1223b1c7a0a. --- src/ngTouch/directive/ngClick.js | 1 - 1 file changed, 1 deletion(-) diff --git a/src/ngTouch/directive/ngClick.js b/src/ngTouch/directive/ngClick.js index 870f19c97821..10ae3efc07bb 100644 --- a/src/ngTouch/directive/ngClick.js +++ b/src/ngTouch/directive/ngClick.js @@ -169,7 +169,6 @@ ngTouch.directive('ngClick', ['$parse', '$timeout', '$rootElement', function preventGhostClick(x, y) { if (!touchCoordinates) { $rootElement[0].addEventListener('click', onClick, true); - $rootElement[0].addEventListener('mousedown', onClick, true); $rootElement[0].addEventListener('touchstart', onTouchStart, true); touchCoordinates = []; } From 66d0419817e387ac5f0719150c4e258de84cb75f Mon Sep 17 00:00:00 2001 From: Tyler Eich Date: Tue, 6 May 2014 19:16:35 -0400 Subject: [PATCH 6/6] feat(input): add input type=range support Bind model of to number (like ) rather than string. Range inputs represent numerical values; therefore, a numerical binding makes more sense than a string binding. Closes #1189, #5892 --- src/ng/directive/input.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/ng/directive/input.js b/src/ng/directive/input.js index e264db38e5b0..20d964aa8b0a 100644 --- a/src/ng/directive/input.js +++ b/src/ng/directive/input.js @@ -159,6 +159,7 @@ var inputType = { */ 'number': numberInputType, + 'range': numberInputType, /**