From efc160be54426203e0ad6d34f5cb7c183218e2f3 Mon Sep 17 00:00:00 2001
From: Igor Minar <igor@angularjs.org>
Date: Fri, 18 Jul 2014 11:12:54 -0700
Subject: [PATCH] perf(ngBindHtml): move addClass to the compile phase

---
 src/ng/directive/ngBind.js      | 25 +++++++++++++++----------
 test/ng/directive/ngBindSpec.js |  8 ++++++++
 2 files changed, 23 insertions(+), 10 deletions(-)

diff --git a/src/ng/directive/ngBind.js b/src/ng/directive/ngBind.js
index 88db9ef1ca61..eae140e5b83e 100644
--- a/src/ng/directive/ngBind.js
+++ b/src/ng/directive/ngBind.js
@@ -177,18 +177,23 @@ var ngBindTemplateDirective = ['$interpolate', function($interpolate) {
    </example>
  */
 var ngBindHtmlDirective = ['$sce', '$parse', function($sce, $parse) {
-  return function(scope, element, attr) {
-    element.addClass('ng-binding').data('$binding', attr.ngBindHtml);
+  return {
+    compile: function (tElement, tAttrs) {
+      tElement.addClass('ng-binding');
 
-    var parsed = $parse(attr.ngBindHtml);
-    var changeDetector = $parse(attr.ngBindHtml, function getStringValue(value) {
+      return function (scope, element, attr) {
+        element.data('$binding', attr.ngBindHtml);
+        var parsed = $parse(attr.ngBindHtml);
+        var changeDetector = $parse(attr.ngBindHtml, function getStringValue(value) {
           return (value || '').toString();
         });
 
-    scope.$watch(changeDetector, function ngBindHtmlWatchAction() {
-      // we re-evaluate the expr because we want a TrustedValueHolderType
-      // for $sce, not a string
-      element.html($sce.getTrustedHtml(parsed(scope)) || '');
-    });
-  };
+        scope.$watch(changeDetector, function ngBindHtmlWatchAction() {
+          // we re-evaluate the expr because we want a TrustedValueHolderType
+          // for $sce, not a string
+          element.html($sce.getTrustedHtml(parsed(scope)) || '');
+        });
+      };
+    }
+  }
 }];
diff --git a/test/ng/directive/ngBindSpec.js b/test/ng/directive/ngBindSpec.js
index 3635d0516d9e..166fdb705a4b 100644
--- a/test/ng/directive/ngBindSpec.js
+++ b/test/ng/directive/ngBindSpec.js
@@ -121,6 +121,14 @@ describe('ngBind*', function() {
 
 
   describe('ngBindHtml', function() {
+
+    it('should add ng-binding class to the element in compile phase', inject(function($compile) {
+      var element = jqLite('<div ng-bind-html="myHtml"></div>');
+      $compile(element);
+      expect(element.hasClass('ng-binding')).toBe(true);
+    }));
+
+
     describe('SCE disabled', function() {
       beforeEach(function() {
         module(function($sceProvider) { $sceProvider.enabled(false); });