diff --git a/src/ng/compile.js b/src/ng/compile.js index e8f582a385d8..9777c49edb1a 100644 --- a/src/ng/compile.js +++ b/src/ng/compile.js @@ -1219,37 +1219,35 @@ function $CompileProvider($provide, $$sanitizeUriProvider) { var attrEndName = false; attr = nAttrs[j]; - if (!msie || msie >= 8 || attr.specified) { - name = attr.name; - value = trim(attr.value); - - // support ngAttr attribute binding - ngAttrName = directiveNormalize(name); - if (isNgAttr = NG_ATTR_BINDING.test(ngAttrName)) { - name = snake_case(ngAttrName.substr(6), '-'); - } + name = attr.name; + value = trim(attr.value); - var directiveNName = ngAttrName.replace(/(Start|End)$/, ''); - if (directiveIsMultiElement(directiveNName)) { - if (ngAttrName === directiveNName + 'Start') { - attrStartName = name; - attrEndName = name.substr(0, name.length - 5) + 'end'; - name = name.substr(0, name.length - 6); - } - } + // support ngAttr attribute binding + ngAttrName = directiveNormalize(name); + if (isNgAttr = NG_ATTR_BINDING.test(ngAttrName)) { + name = snake_case(ngAttrName.substr(6), '-'); + } - nName = directiveNormalize(name.toLowerCase()); - attrsMap[nName] = name; - if (isNgAttr || !attrs.hasOwnProperty(nName)) { - attrs[nName] = value; - if (getBooleanAttrName(node, nName)) { - attrs[nName] = true; // presence means true - } + var directiveNName = ngAttrName.replace(/(Start|End)$/, ''); + if (directiveIsMultiElement(directiveNName)) { + if (ngAttrName === directiveNName + 'Start') { + attrStartName = name; + attrEndName = name.substr(0, name.length - 5) + 'end'; + name = name.substr(0, name.length - 6); } - addAttrInterpolateDirective(node, directives, value, nName, isNgAttr); - addDirective(directives, nName, 'A', maxPriority, ignoreDirective, attrStartName, - attrEndName); } + + nName = directiveNormalize(name.toLowerCase()); + attrsMap[nName] = name; + if (isNgAttr || !attrs.hasOwnProperty(nName)) { + attrs[nName] = value; + if (getBooleanAttrName(node, nName)) { + attrs[nName] = true; // presence means true + } + } + addAttrInterpolateDirective(node, directives, value, nName, isNgAttr); + addDirective(directives, nName, 'A', maxPriority, ignoreDirective, attrStartName, + attrEndName); } // use class as directive diff --git a/src/ng/directive/a.js b/src/ng/directive/a.js index 850d7d6d3093..eef5e2ddd96c 100644 --- a/src/ng/directive/a.js +++ b/src/ng/directive/a.js @@ -16,22 +16,6 @@ var htmlAnchorDirective = valueFn({ restrict: 'E', compile: function(element, attr) { - - if (msie <= 8) { - - // turn link into a stylable link in IE - // but only if it doesn't have name attribute, in which case it's an anchor - if (!attr.href && !attr.name) { - attr.$set('href', ''); - } - - // add a comment node to anchors to workaround IE bug that causes element content to be reset - // to new attribute content if attribute is updated with value containing @ and element also - // contains value with @ - // see issue #1949 - element.append(document.createComment('IE fix')); - } - if (!attr.href && !attr.xlinkHref && !attr.name) { return function(scope, element) { // SVGAElement does not use the href attribute, but rather the 'xlinkHref' attribute. diff --git a/src/ng/httpBackend.js b/src/ng/httpBackend.js index 78d04cfa24b9..9f45ca70aaaa 100644 --- a/src/ng/httpBackend.js +++ b/src/ng/httpBackend.js @@ -1,17 +1,11 @@ 'use strict'; function createXhr(method) { - //if IE and the method is not RFC2616 compliant, or if XMLHttpRequest - //is not available, try getting an ActiveXObject. Otherwise, use XMLHttpRequest - //if it is available - if (msie <= 8 && (!method.match(/^(get|post|head|put|delete|options)$/i) || - !window.XMLHttpRequest)) { - return new window.ActiveXObject("Microsoft.XMLHTTP"); - } else if (window.XMLHttpRequest) { - return new window.XMLHttpRequest(); - } + if (window.XMLHttpRequest) { + return new window.XMLHttpRequest(); + } - throw minErr('$httpBackend')('noxhr', "This browser does not support XMLHttpRequest."); + throw minErr('$httpBackend')('noxhr', "This browser does not support XMLHttpRequest."); } /** diff --git a/src/ng/sanitizeUri.js b/src/ng/sanitizeUri.js index faceda8f56de..d6cd378cec20 100644 --- a/src/ng/sanitizeUri.js +++ b/src/ng/sanitizeUri.js @@ -61,12 +61,9 @@ function $$SanitizeUriProvider() { return function sanitizeUri(uri, isImage) { var regex = isImage ? imgSrcSanitizationWhitelist : aHrefSanitizationWhitelist; var normalizedVal; - // NOTE: urlResolve() doesn't support IE < 8 so we don't sanitize for that case. - if (!msie || msie >= 8 ) { - normalizedVal = urlResolve(uri).href; - if (normalizedVal !== '' && !normalizedVal.match(regex)) { - return 'unsafe:'+normalizedVal; - } + normalizedVal = urlResolve(uri).href; + if (normalizedVal !== '' && !normalizedVal.match(regex)) { + return 'unsafe:'+normalizedVal; } return uri; }; diff --git a/src/ngScenario/browserTrigger.js b/src/ngScenario/browserTrigger.js index 478853e28512..d1466dbb2787 100644 --- a/src/ngScenario/browserTrigger.js +++ b/src/ngScenario/browserTrigger.js @@ -52,96 +52,70 @@ return keys.indexOf(key) !== -1; } - if (msie < 9) { - if (inputType == 'radio' || inputType == 'checkbox') { - element.checked = !element.checked; + var evnt; + if(/transitionend/.test(eventType)) { + if(window.WebKitTransitionEvent) { + evnt = new WebKitTransitionEvent(eventType, eventData); + evnt.initEvent(eventType, false, true); } - - // WTF!!! Error: Unspecified error. - // Don't know why, but some elements when detached seem to be in inconsistent state and - // calling .fireEvent() on them will result in very unhelpful error (Error: Unspecified error) - // forcing the browser to compute the element position (by reading its CSS) - // puts the element in consistent state. - element.style.posLeft; - - // TODO(vojta): create event objects with pressed keys to get it working on IE<9 - var ret = element.fireEvent('on' + eventType); - if (inputType == 'submit') { - while(element) { - if (element.nodeName.toLowerCase() == 'form') { - element.fireEvent('onsubmit'); - break; - } - element = element.parentNode; - } - } - return ret; - } else { - var evnt; - if(/transitionend/.test(eventType)) { - if(window.WebKitTransitionEvent) { - evnt = new WebKitTransitionEvent(eventType, eventData); - evnt.initEvent(eventType, false, true); + else { + try { + evnt = new TransitionEvent(eventType, eventData); } - else { - try { - evnt = new TransitionEvent(eventType, eventData); - } - catch(e) { - evnt = document.createEvent('TransitionEvent'); - evnt.initTransitionEvent(eventType, null, null, null, eventData.elapsedTime || 0); - } + catch(e) { + evnt = document.createEvent('TransitionEvent'); + evnt.initTransitionEvent(eventType, null, null, null, eventData.elapsedTime || 0); } } - else if(/animationend/.test(eventType)) { - if(window.WebKitAnimationEvent) { - evnt = new WebKitAnimationEvent(eventType, eventData); - evnt.initEvent(eventType, false, true); - } - else { - try { - evnt = new AnimationEvent(eventType, eventData); - } - catch(e) { - evnt = document.createEvent('AnimationEvent'); - evnt.initAnimationEvent(eventType, null, null, null, eventData.elapsedTime || 0); - } - } + } + else if(/animationend/.test(eventType)) { + if(window.WebKitAnimationEvent) { + evnt = new WebKitAnimationEvent(eventType, eventData); + evnt.initEvent(eventType, false, true); } else { - evnt = document.createEvent('MouseEvents'); - x = x || 0; - y = y || 0; - evnt.initMouseEvent(eventType, true, true, window, 0, x, y, x, y, pressed('ctrl'), - pressed('alt'), pressed('shift'), pressed('meta'), 0, element); + try { + evnt = new AnimationEvent(eventType, eventData); + } + catch(e) { + evnt = document.createEvent('AnimationEvent'); + evnt.initAnimationEvent(eventType, null, null, null, eventData.elapsedTime || 0); + } } + } + else { + evnt = document.createEvent('MouseEvents'); + x = x || 0; + y = y || 0; + evnt.initMouseEvent(eventType, true, true, window, 0, x, y, x, y, pressed('ctrl'), + pressed('alt'), pressed('shift'), pressed('meta'), 0, element); + } - /* we're unable to change the timeStamp value directly so this - * is only here to allow for testing where the timeStamp value is - * read */ - evnt.$manualTimeStamp = eventData.timeStamp; + /* we're unable to change the timeStamp value directly so this + * is only here to allow for testing where the timeStamp value is + * read */ + evnt.$manualTimeStamp = eventData.timeStamp; - if(!evnt) return; + if(!evnt) return; - var originalPreventDefault = evnt.preventDefault, - appWindow = element.ownerDocument.defaultView, - fakeProcessDefault = true, - finalProcessDefault, - angular = appWindow.angular || {}; + var originalPreventDefault = evnt.preventDefault, + appWindow = element.ownerDocument.defaultView, + fakeProcessDefault = true, + finalProcessDefault, + angular = appWindow.angular || {}; - // igor: temporary fix for https://bugzilla.mozilla.org/show_bug.cgi?id=684208 - angular['ff-684208-preventDefault'] = false; - evnt.preventDefault = function() { - fakeProcessDefault = false; - return originalPreventDefault.apply(evnt, arguments); - }; + // igor: temporary fix for https://bugzilla.mozilla.org/show_bug.cgi?id=684208 + angular['ff-684208-preventDefault'] = false; + evnt.preventDefault = function() { + fakeProcessDefault = false; + return originalPreventDefault.apply(evnt, arguments); + }; - element.dispatchEvent(evnt); - finalProcessDefault = !(angular['ff-684208-preventDefault'] || !fakeProcessDefault); + element.dispatchEvent(evnt); + finalProcessDefault = !(angular['ff-684208-preventDefault'] || !fakeProcessDefault); - delete angular['ff-684208-preventDefault']; + delete angular['ff-684208-preventDefault']; - return finalProcessDefault; - } + return finalProcessDefault; }; }()); diff --git a/test/AngularSpec.js b/test/AngularSpec.js index bece0ef33e6b..7267d9118510 100644 --- a/test/AngularSpec.js +++ b/test/AngularSpec.js @@ -371,9 +371,6 @@ describe('angular', function() { it('should correctly test for keys that are present on Object.prototype', function() { /* jshint -W001 */ - // MS IE8 just doesn't work for this kind of thing, since "for ... in" doesn't return - // things like hasOwnProperty even if it is explicitly defined on the actual object! - if (msie<=8) return; expect(equals({}, {hasOwnProperty: 1})).toBe(false); expect(equals({}, {toString: null})).toBe(false); }); @@ -1033,15 +1030,13 @@ describe('angular', function() { expect(div.childNodes[0].getAttribute('ngtest:attr')).toBe('bar'); }); - if (!msie || msie >= 9) { - it('should correctly detect node name with "namespace" when xmlns is NOT defined', function() { - var div = jqLite('
' + - '' + - '
')[0]; - expect(nodeName_(div.childNodes[0])).toBe('ngtest:foo'); - expect(div.childNodes[0].getAttribute('ngtest:attr')).toBe('bar'); - }); - } + it('should correctly detect node name with "namespace" when xmlns is NOT defined', function() { + var div = jqLite('
' + + '' + + '
')[0]; + expect(nodeName_(div.childNodes[0])).toBe('ngtest:foo'); + expect(div.childNodes[0].getAttribute('ngtest:attr')).toBe('bar'); + }); }); diff --git a/test/jqLiteSpec.js b/test/jqLiteSpec.js index 356d2a36167f..f52bd4058246 100644 --- a/test/jqLiteSpec.js +++ b/test/jqLiteSpec.js @@ -594,16 +594,7 @@ describe('jqLite', function() { expect(input.attr('READONLY')).toBe('readonly'); input.attr('readonly', false); - - // attr('readonly') fails in jQuery 1.6.4, so we have to bypass it - //expect(input.attr('readOnly')).toBeUndefined(); - //expect(input.attr('readonly')).toBeUndefined(); - if (msie < 9) { - expect(input[0].getAttribute('readonly')).toBe(''); - } else { - expect(input[0].getAttribute('readonly')).toBe(null); - } - //expect('readOnly' in input[0].attributes).toBe(false); + expect(input[0].getAttribute('readonly')).toBe(null); input.attr('readOnly', 'READonly'); expect(input.attr('readonly')).toBe('readonly'); @@ -877,26 +868,15 @@ describe('jqLite', function() { expect(jqLite(b).css('margin')).toEqual('3px'); selector.css('margin', ''); - if (msie <= 8) { - expect(jqLite(a).css('margin')).toBe('auto'); - expect(jqLite(b).css('margin')).toBe('auto'); - } else { - expect(jqLite(a).css('margin')).toBeFalsy(); - expect(jqLite(b).css('margin')).toBeFalsy(); - } + expect(jqLite(a).css('margin')).toBeFalsy(); + expect(jqLite(b).css('margin')).toBeFalsy(); }); it('should set a bunch of css properties specified via an object', function() { - if (msie <= 8) { - expect(jqLite(a).css('margin')).toBe('auto'); - expect(jqLite(a).css('padding')).toBe('0px'); - expect(jqLite(a).css('border')).toBeUndefined(); - } else { - expect(jqLite(a).css('margin')).toBeFalsy(); - expect(jqLite(a).css('padding')).toBeFalsy(); - expect(jqLite(a).css('border')).toBeFalsy(); - } + expect(jqLite(a).css('margin')).toBeFalsy(); + expect(jqLite(a).css('padding')).toBeFalsy(); + expect(jqLite(a).css('border')).toBeFalsy(); jqLite(a).css({'margin': '1px', 'padding': '2px', 'border': ''}); @@ -1185,14 +1165,7 @@ describe('jqLite', function() { if (window.jQuery) return; var browserMoveTrigger = function(from, to){ var fireEvent = function(type, element, relatedTarget){ - var evnt, msie = parseInt((/msie (\d+)/.exec(navigator.userAgent.toLowerCase()) || [])[1]); - if (msie < 9){ - evnt = document.createEventObject(); - evnt.srcElement = element; - evnt.relatedTarget = relatedTarget; - element.fireEvent('on' + type, evnt); - return; - } + var evnt; evnt = document.createEvent('MouseEvents'); var originalPreventDefault = evnt.preventDefault, @@ -1535,8 +1508,6 @@ describe('jqLite', function() { }); it('should select all types iframe contents', function() { - // IE8 does not like this test, although the functionality may still work there. - if (msie < 9) return; var iframe_ = document.createElement('iframe'); var tested = false; var iframe = jqLite(iframe_); diff --git a/test/ng/compileSpec.js b/test/ng/compileSpec.js index ddde992ab454..be1f0608ed28 100755 --- a/test/ng/compileSpec.js +++ b/test/ng/compileSpec.js @@ -389,7 +389,6 @@ describe('$compile', function() { // it turns out that when a browser plugin is bound to an DOM element (typically ), // the plugin's context rather than the usual DOM apis are exposed on this element, so // childNodes might not exist. - if (msie < 9) return; element = jqLite('
{{1+2}}
'); diff --git a/test/ng/directive/aSpec.js b/test/ng/directive/aSpec.js index bd9f246dc0cd..e374a744f837 100644 --- a/test/ng/directive/aSpec.js +++ b/test/ng/directive/aSpec.js @@ -22,29 +22,19 @@ describe('a', function() { element = $compile('empty link')($rootScope); - if (msie < 9) { + event = document.createEvent('MouseEvent'); + event.initMouseEvent( + 'click', true, true, window, 0, 0, 0, 0, 0, false, false, false, false, 0, null); - event = document.createEventObject(); - expect(event.returnValue).not.toBeDefined(); - element[0].fireEvent('onclick', event); - expect(event.returnValue).toEqual(false); + event.preventDefaultOrg = event.preventDefault; + event.preventDefault = function() { + preventDefaultCalled = true; + if (this.preventDefaultOrg) this.preventDefaultOrg(); + }; - } else { + element[0].dispatchEvent(event); - event = document.createEvent('MouseEvent'); - event.initMouseEvent( - 'click', true, true, window, 0, 0, 0, 0, 0, false, false, false, false, 0, null); - - event.preventDefaultOrg = event.preventDefault; - event.preventDefault = function() { - preventDefaultCalled = true; - if (this.preventDefaultOrg) this.preventDefaultOrg(); - }; - - element[0].dispatchEvent(event); - - expect(preventDefaultCalled).toEqual(true); - } + expect(preventDefaultCalled).toEqual(true); expect(document.location.href).toEqual(orgLocation); }); @@ -97,30 +87,19 @@ describe('a', function() { element = $compile('empty link')($rootScope); child = element.children('a'); - if (msie < 9) { - - event = document.createEventObject(); - expect(event.returnValue).not.toBeDefined(); - child[0].fireEvent('onclick', event); - expect(event.returnValue).toEqual(false); - - } else { - - event = document.createEvent('MouseEvent'); - event.initMouseEvent( - 'click', true, true, window, 0, 0, 0, 0, 0, false, false, false, false, 0, null); - - event.preventDefaultOrg = event.preventDefault; - event.preventDefault = function() { - preventDefaultCalled = true; - if (this.preventDefaultOrg) this.preventDefaultOrg(); - }; + event = document.createEvent('MouseEvent'); + event.initMouseEvent( + 'click', true, true, window, 0, 0, 0, 0, 0, false, false, false, false, 0, null); - child[0].dispatchEvent(event); + event.preventDefaultOrg = event.preventDefault; + event.preventDefault = function() { + preventDefaultCalled = true; + if (this.preventDefaultOrg) this.preventDefaultOrg(); + }; - expect(preventDefaultCalled).toEqual(true); - } + child[0].dispatchEvent(event); + expect(preventDefaultCalled).toEqual(true); expect(document.location.href).toEqual(orgLocation); }); diff --git a/test/ng/directive/booleanAttrsSpec.js b/test/ng/directive/booleanAttrsSpec.js index 859566bbbc76..afe7aba28bd2 100644 --- a/test/ng/directive/booleanAttrsSpec.js +++ b/test/ng/directive/booleanAttrsSpec.js @@ -89,8 +89,6 @@ describe('boolean attr directives', function() { it('should throw an exception if binding to multiple attribute', inject(function($rootScope, $compile) { - if (msie < 9) return; //IE8 doesn't support biding to boolean attributes - expect(function() { $compile(''); }).toThrowMinErr('$compile', 'selmulti', 'Binding to the \'multiple\' attribute is not supported. ' + diff --git a/test/ng/directive/formSpec.js b/test/ng/directive/formSpec.js index 4a82a01e6bb3..febe0d8ebe54 100644 --- a/test/ng/directive/formSpec.js +++ b/test/ng/directive/formSpec.js @@ -257,17 +257,13 @@ describe('form', function() { reloadPrevented = e.defaultPrevented || (e.returnValue === false); }; - // native dom event listeners in IE8 fire in LIFO order so we have to register them - // there in different order than in other browsers - if (msie==8) addEventListenerFn(doc[0], 'submit', assertPreventDefaultListener); - $compile(doc)(scope); scope.submitMe = function() { submitted = true; }; - if (msie!=8) addEventListenerFn(doc[0], 'submit', assertPreventDefaultListener); + addEventListenerFn(doc[0], 'submit', assertPreventDefaultListener); browserTrigger(doc.find('input')); @@ -316,13 +312,9 @@ describe('form', function() { reloadPrevented = e.defaultPrevented || (e.returnValue === false); }; - // native dom event listeners in IE8 fire in LIFO order so we have to register them - // there in different order than in other browsers - if (msie == 8) addEventListenerFn(form[0], 'submit', assertPreventDefaultListener); - $compile(doc)(scope); - if (msie != 8) addEventListenerFn(form[0], 'submit', assertPreventDefaultListener); + addEventListenerFn(form[0], 'submit', assertPreventDefaultListener); browserTrigger(doc.find('button'), 'click'); @@ -331,11 +323,6 @@ describe('form', function() { waitsFor(function() { return nextTurn; }); - - // I can't get IE8 to automatically trigger submit in this test, in production it does it - // properly - if (msie == 8) browserTrigger(form, 'submit'); - runs(function() { expect(doc.html()).toBe(''); expect(destroyed).toBe(true); @@ -345,12 +332,6 @@ describe('form', function() { // the issue in the wild, I'm not going to bother to do it // now. (i) - // IE9 and IE10 are special and don't fire submit event when form was destroyed - if (msie < 9) { - expect(reloadPrevented).toBe(true); - $timeout.flush(); - } - // prevent mem leak in test removeEventListenerFn(form[0], 'submit', assertPreventDefaultListener); }); diff --git a/test/ng/directive/inputSpec.js b/test/ng/directive/inputSpec.js index a10676732a14..1fe223c03010 100644 --- a/test/ng/directive/inputSpec.js +++ b/test/ng/directive/inputSpec.js @@ -1229,47 +1229,43 @@ describe('input', function() { expect(scope.name).toEqual('adam'); }); - if (!msie || msie >= 9) { - describe('compositionevents', function() { - it('should not update the model between "compositionstart" and "compositionend" on non android', inject(function($sniffer) { - $sniffer.android = false; - - compileInput(''); - changeInputValueTo('a'); - expect(scope.name).toEqual('a'); - browserTrigger(inputElm, 'compositionstart'); - changeInputValueTo('adam'); - expect(scope.name).toEqual('a'); - browserTrigger(inputElm, 'compositionend'); - changeInputValueTo('adam'); - expect(scope.name).toEqual('adam'); - })); + describe('compositionevents', function() { + it('should not update the model between "compositionstart" and "compositionend" on non android', inject(function($sniffer) { + $sniffer.android = false; - it('should update the model between "compositionstart" and "compositionend" on android', inject(function($sniffer) { - $sniffer.android = true; - - compileInput(''); - changeInputValueTo('a'); - expect(scope.name).toEqual('a'); - browserTrigger(inputElm, 'compositionstart'); - changeInputValueTo('adam'); - expect(scope.name).toEqual('adam'); - browserTrigger(inputElm, 'compositionend'); - changeInputValueTo('adam2'); - expect(scope.name).toEqual('adam2'); - })); - }); - } + compileInput(''); + changeInputValueTo('a'); + expect(scope.name).toEqual('a'); + browserTrigger(inputElm, 'compositionstart'); + changeInputValueTo('adam'); + expect(scope.name).toEqual('a'); + browserTrigger(inputElm, 'compositionend'); + changeInputValueTo('adam'); + expect(scope.name).toEqual('adam'); + })); - it('should update the model on "compositionend"', function() { - compileInput(''); - if (!msie || msie >= 9) { + it('should update the model between "compositionstart" and "compositionend" on android', inject(function($sniffer) { + $sniffer.android = true; + + compileInput(''); + changeInputValueTo('a'); + expect(scope.name).toEqual('a'); browserTrigger(inputElm, 'compositionstart'); - changeInputValueTo('caitp'); - expect(scope.name).toBeUndefined(); + changeInputValueTo('adam'); + expect(scope.name).toEqual('adam'); browserTrigger(inputElm, 'compositionend'); - expect(scope.name).toEqual('caitp'); - } + changeInputValueTo('adam2'); + expect(scope.name).toEqual('adam2'); + })); + }); + + it('should update the model on "compositionend"', function() { + compileInput(''); + browserTrigger(inputElm, 'compositionstart'); + changeInputValueTo('caitp'); + expect(scope.name).toBeUndefined(); + browserTrigger(inputElm, 'compositionend'); + expect(scope.name).toEqual('caitp'); }); it('should not dirty the model on an input event in response to a placeholder change', inject(function($sniffer) { diff --git a/test/ng/directive/ngRepeatSpec.js b/test/ng/directive/ngRepeatSpec.js index 609d232b6f0f..c63b1faa474f 100644 --- a/test/ng/directive/ngRepeatSpec.js +++ b/test/ng/directive/ngRepeatSpec.js @@ -925,25 +925,21 @@ describe('ngRepeat', function() { })); - if (!msie || msie > 8) { - // only IE>8 supports element directives - - it('should work when placed on a root element of element directive with ASYNC replaced template', - inject(function($templateCache, $compile, $rootScope) { - $compileProvider.directive('replaceMeWithRepeater', function() { - return { - restrict: 'E', - replace: true, - templateUrl: 'replace-me-with-repeater.html' - }; - }); - $templateCache.put('replace-me-with-repeater.html', '
{{i}}
'); - element = $compile('
')($rootScope); - expect(element.text()).toBe(''); - $rootScope.$apply(); - expect(element.text()).toBe('123'); - })); - } + it('should work when placed on a root element of element directive with ASYNC replaced template', + inject(function($templateCache, $compile, $rootScope) { + $compileProvider.directive('replaceMeWithRepeater', function() { + return { + restrict: 'E', + replace: true, + templateUrl: 'replace-me-with-repeater.html' + }; + }); + $templateCache.put('replace-me-with-repeater.html', '
{{i}}
'); + element = $compile('
')($rootScope); + expect(element.text()).toBe(''); + $rootScope.$apply(); + expect(element.text()).toBe('123'); + })); it('should work when combined with an ASYNC template that loads after the first digest', inject(function($httpBackend, $compile, $rootScope) { $compileProvider.directive('test', function() { diff --git a/test/ng/httpSpec.js b/test/ng/httpSpec.js index c2ad25f0ce82..f12f6ef80a16 100644 --- a/test/ng/httpSpec.js +++ b/test/ng/httpSpec.js @@ -343,7 +343,6 @@ describe('$http', function() { }); it('should not double quote dates', function() { - if (msie < 9) return; $httpBackend.expect('GET', '/url?date=2014-07-15T17:30:00.000Z').respond(''); $http({url: '/url', params: {date:new Date('2014-07-15T17:30:00.000Z')}, method: 'GET'}); }); diff --git a/test/ng/locationSpec.js b/test/ng/locationSpec.js index 6e43da0c1dd5..861079819569 100644 --- a/test/ng/locationSpec.js +++ b/test/ng/locationSpec.js @@ -1266,34 +1266,30 @@ describe('$location', function() { ); }); - // don't run next tests on IE<9, as browserTrigger does not simulate pressed keys - if (!msie || msie >= 9) { - - it('should not rewrite when clicked with ctrl pressed', function() { - configureService({linkHref: '/a?b=c', html5Mode: true, supportHist: true}); - inject( - initBrowser(), - initLocation(), - function($browser) { - browserTrigger(link, 'click', { keys: ['ctrl'] }); - expectNoRewrite($browser); - } - ); - }); + it('should not rewrite when clicked with ctrl pressed', function() { + configureService({linkHref: '/a?b=c', html5Mode: true, supportHist: true}); + inject( + initBrowser(), + initLocation(), + function($browser) { + browserTrigger(link, 'click', { keys: ['ctrl'] }); + expectNoRewrite($browser); + } + ); + }); - it('should not rewrite when clicked with meta pressed', function() { - configureService({linkHref: '/a?b=c', html5Mode: true, supportHist: true}); - inject( - initBrowser(), - initLocation(), - function($browser) { - browserTrigger(link, 'click', { keys: ['meta'] }); - expectNoRewrite($browser); - } - ); - }); - } + it('should not rewrite when clicked with meta pressed', function() { + configureService({linkHref: '/a?b=c', html5Mode: true, supportHist: true}); + inject( + initBrowser(), + initLocation(), + function($browser) { + browserTrigger(link, 'click', { keys: ['meta'] }); + expectNoRewrite($browser); + } + ); + }); it('should not mess up hash urls when clicking on links in hashbang mode', function() { diff --git a/test/ngMock/angular-mocksSpec.js b/test/ngMock/angular-mocksSpec.js index d8e5b2226d1a..ef038082eb66 100644 --- a/test/ngMock/angular-mocksSpec.js +++ b/test/ngMock/angular-mocksSpec.js @@ -697,7 +697,6 @@ describe('ngMock', function() { /* jshint -W001 */ // MS IE8 just doesn't work for this kind of thing, since "for ... in" doesn't return // things like hasOwnProperty even if it is explicitly defined on the actual object! - if ($sniffer.msie<=8) return; $rootScope.hasOwnProperty = 'X'; expect(d($rootScope)).toMatch(/Scope\(.*\): \{/); expect(d($rootScope)).toMatch(/hasOwnProperty: "X"/); @@ -855,8 +854,6 @@ describe('ngMock', function() { // when thrown from a function defined on window (which `inject` is). it('should not change thrown Errors', inject(function($sniffer) { - if ($sniffer.msie <= 8) return; - expect(function() { inject(function() { throw new Error('test message'); @@ -865,8 +862,6 @@ describe('ngMock', function() { })); it('should not change thrown strings', inject(function($sniffer) { - if ($sniffer.msie <= 8) return; - expect(function() { inject(function() { throw 'test message'; diff --git a/test/ngTouch/directive/ngSwipeSpec.js b/test/ngTouch/directive/ngSwipeSpec.js index 5b8fa7537dd5..43d49b43097d 100644 --- a/test/ngTouch/directive/ngSwipeSpec.js +++ b/test/ngTouch/directive/ngSwipeSpec.js @@ -14,14 +14,6 @@ var swipeTests = function(description, restrictBrowsers, startEvent, moveEvent, } } - // Skip tests on IE < 9. These versions of IE don't support createEvent(), and so - // we cannot control the (x,y) position of events. - // It works fine in IE 8 under manual testing. - var msie = +((/msie (\d+)/.exec(navigator.userAgent.toLowerCase()) || [])[1]); - if (msie < 9) { - return; - } - beforeEach(function() { module('ngTouch'); }); diff --git a/test/ngTouch/swipeSpec.js b/test/ngTouch/swipeSpec.js index daa5a73f92df..416d9f5d632d 100644 --- a/test/ngTouch/swipeSpec.js +++ b/test/ngTouch/swipeSpec.js @@ -4,14 +4,6 @@ describe('$swipe', function() { var element; var events; - // Skip tests on IE < 9. These versions of IE don't support createEvent(), and so - // we cannot control the (x,y) position of events. - // It works fine in IE 8 under manual testing. - var msie = +((/msie (\d+)/.exec(navigator.userAgent.toLowerCase()) || [])[1]); - if (msie < 9) { - return; - } - beforeEach(function() { module('ngTouch'); inject(function($compile, $rootScope) {