fix(language-service): provide dom event completions

[atscott]

Native DOM events were previously not included in the completions in Ivy
because the dom schema registry would filter out events completely. This
change updates the registry to include events in the private
element->property map and excludes events from lookups outside of the
new allKnownEventsOfElement function.

fixes angular/vscode-ng-language-service#1479

Reviewer notes: Autocompletion in the VE language service did include native events so this addresses a regression from previous behavior.

angular/packages/language-service/src/completions.ts

Lines 253 to 255 in faf9f5a

	case ATTR.IDENT_EVENT:
	// event binding via on- or ()
	results.push(...eventNames(elem.name), ...ngAttrs.outputs);

angular/packages/language-service/src/html_info.ts

Lines 449 to 451 in faf9f5a

	export function eventNames(elementName: string): string[] {
	return SchemaInformation.instance.eventsOf(elementName);
	}

angular/packages/language-service/src/html_info.ts

Lines 424 to 427 in faf9f5a

	eventsOf(elementName: string): string[] {
	const elementType = this.schema[elementName.toLowerCase()] || {};
	return Object.keys(elementType).filter(property => elementType[property] === EVENT);
	}

[IgorMinar]

LGTM. As far as I can tell this doesn't change the security properties of the schema validation, so I'm ok with not blocking this on the ISE review, but I do want to give them a heads up.

@bjarkler - fyi: we are making a change to the DOM security schema that looks a bit dangerous on the surface, but in reality it doesn't change anything significant, and doesn't have any security impact.

Reviewed-for: fw-security

[bjarkler]

My only security concern is that the current change makes it a little bit easier for a future change to expose the event properties by accident. You could fix that by moving the events into a separate event schema table so that you wouldn't have to apply the current filtering in all the other getters. But in any case, this LGTM.

[IgorMinar]

thanks @bjarkler! I agree with your suggestion, @atscott could you please give it a shot? thank you!

[jelbourn]

LGTM

[jelbourn]

LGTM

Reviewed-for: fw-security

[atscott]

presubmit

[atscott]

merge assistance: All required reviews are approved. Pullapprove seems a bit stuck

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}