Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change doc.update() parameter type to Partial<T> #1247

Merged
merged 3 commits into from
Oct 12, 2017
Merged

Change doc.update() parameter type to Partial<T> #1247

merged 3 commits into from
Oct 12, 2017

Commits on Oct 11, 2017

  1. Remove strongly typed parameters for update and set 

    Strongly typing the parameter requires that the object that's passed in is a complete match for the model. Normally though, you should be able to pass whatever you want to set and update (any number of fields in the model) and it should work.
    @markgoho
    markgoho authored Oct 11, 2017
    Configuration menu
    Copy the full SHA
    b7e3c50 View commit details
    Browse the repository at this point in the history

  2. Update document.ts

    @markgoho
    markgoho authored Oct 11, 2017
    Configuration menu
    Copy the full SHA
    c22638f View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2017

  1. leave .set as is, changing .update to partial

    @markgoho
    markgoho authored Oct 12, 2017
    Configuration menu
    Copy the full SHA
    d3699e0 View commit details
    Browse the repository at this point in the history