Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Fix for the firebase/app export in Node #1821

Merged
merged 1 commit into from
Aug 19, 2018
Merged

fix(core): Fix for the firebase/app export in Node #1821

merged 1 commit into from
Aug 19, 2018

Conversation

jamesdaniels
Copy link
Member

Checklist

  • Issue number for this PR: #nnn (required)
  • Docs included?: (yes/no; required for all API/functional changes)
  • Test units included?: (yes/no; required)
  • In a clean directory, yarn install, yarn test run successfully? (yes/no; required)

Description

While not optimal, this will fix the .filter for undefined issues while compiling for the server for now.

  • Import the ESM version of firebase/app
  • Ignore the type errors
  • Drop <any> from config, as firebase is now an any itself
  • Drop the trailing comma to allow building on older versions of Node (namely 6.x)

Code sample

@jamesdaniels jamesdaniels mentioned this pull request Aug 17, 2018
Closed
davideast
davideast approved these changes Aug 19, 2018
View reviewed changes
Copy link
Member

@davideast davideast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davideast davideast merged commit f1014ee into angular:master Aug 19, 2018
sulco pushed a commit to sulco/angularfire2 that referenced this pull request Sep 3, 2018
@jamesdaniels @sulco
fix(core): Fix for the firebase ES export in Node (angular#1821)
1d46d0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davideast davideast davideast approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesdaniels @davideast @googlebot