Skip to content

Commit 60e1c98

Browse files
author
Vivian Hu
committed
more change based on code review
1 parent db64ce2 commit 60e1c98

File tree

4 files changed

+5
-7
lines changed

4 files changed

+5
-7
lines changed

src/demo-app/list/list-demo.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ <h2>Nav lists</h2>
107107
<div>
108108
<h2>Action list</h2>
109109
<mat-action-list>
110-
<button mat-list-item *ngFor="let link of links" (click)="alertItem(link.name)">
110+
<button mat-list-item *ngFor="let link of links" (click)="alertItem(link.name)">
111111
{{link.name}}
112112
</button>
113113
</mat-action-list>

src/lib/list/list.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,7 @@ Simple action lists can use the `mat-list-item` attribute on button tag elements
5050

5151
```html
5252
<mat-action-list>
53-
<button mat-list-item *ngFor="let link of links" (click)="alertItem(link.name)">
54-
{{link.name}}
55-
</button>
53+
<button mat-list-item *ngFor="let link of links"> {{link.name}} </button>
5654
</mat-action-list>
5755
```
5856

src/lib/list/list.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ $mat-list-item-inset-divider-offset: 72px;
263263
}
264264

265265
mat-action-list {
266-
//remove the native button look and make is look like a list item
266+
//remove the native button look and make it look like a list item
267267
button {
268268
background: none;
269269
color: inherit;

src/lib/list/list.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ describe('MatList', () => {
145145
items.forEach(item => expect(item._isRippleDisabled()).toBe(true));
146146
});
147147

148-
it('action list should be created successfully', () => {
148+
it('should create an action list', () => {
149149
let fixture = TestBed.createComponent(ActionListWithOneItem);
150150
fixture.detectChanges();
151151

@@ -207,7 +207,7 @@ class NavListWithOneAnchorItem extends BaseTestList {
207207
@Component({template: `
208208
<mat-action-list>
209209
<button mat-list-item>
210-
Paprika
210+
Paprika
211211
</button>
212212
</mat-action-list>`})
213213
class ActionListWithOneItem extends BaseTestList {

0 commit comments

Comments
 (0)